Skip to content

Filter out IPv6 addresses in Govee Light Local#151540

Merged
frenck merged 1 commit intodevfrom
govee_ll_fix_ipv6
Sep 2, 2025
Merged

Filter out IPv6 addresses in Govee Light Local#151540
frenck merged 1 commit intodevfrom
govee_ll_fix_ipv6

Conversation

@abmantis
Copy link
Member

@abmantis abmantis commented Sep 1, 2025

Proposed change

Since the library does not support IPv6 addresses, the integration currently fails if IPv6 is enabled on the host.

This issue was introduced by #128123

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes Govee Lights Local fails to set up #151425
  • This PR is related to issue:
  • Link to documentation pull request:
  • Link to developer documentation pull request:
  • Link to frontend pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

Copilot AI review requested due to automatic review settings September 1, 2025 22:09
@home-assistant
Copy link

home-assistant bot commented Sep 1, 2025

Hey there @Galorhallen, mind taking a look at this pull request as it has been labeled with an integration (govee_light_local) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of govee_light_local can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign govee_light_local Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a compatibility issue with IPv6 addresses in the Govee Light Local integration. The underlying library does not support IPv6, causing the integration to fail when IPv6 is enabled on the host system.

  • Filters out IPv6 addresses from network interface discovery
  • Updates type hints to only accept IPv4Address objects
  • Removes unnecessary whitespace

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
homeassistant/components/govee_light_local/coordinator.py Updates type hints to accept only IPv4Address and removes IPv6Address import
homeassistant/components/govee_light_local/config_flow.py Filters IPv6 addresses during device discovery and updates function signature
homeassistant/components/govee_light_local/init.py Filters IPv6 addresses when initializing the coordinator

@abmantis abmantis added this to the 2025.9.0 milestone Sep 1, 2025
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @abmantis 👍

../Frenck

@frenck frenck merged commit 4b7817f into dev Sep 2, 2025
34 checks passed
@frenck frenck deleted the govee_ll_fix_ipv6 branch September 2, 2025 08:27
@itewk
Copy link
Contributor

itewk commented Sep 2, 2025

apologies for the regression :(

@abmantis
Copy link
Member Author

abmantis commented Sep 2, 2025

apologies for the regression :(

No worries, it happens! 😄

@github-actions github-actions bot locked and limited conversation to collaborators Sep 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Govee Lights Local fails to set up

4 participants