Add multiple NICs in govee_light_local by itewk · Pull Request #128123 · home-assistant/core

itewk · 2024-10-10T20:10:02Z

Proposed change

Currently govee_light_local can only discover and control devices on the primary NIC.
This adds support for discovering and controlling devices on any NIC with an IPv4 address.

This is built upon @mill1000 work in dev...mill1000:core:issue/govee_discovery

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes Govee light local doesn't use all available network interfaces in discovery #124339

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
I have followed the perfect PR recommendations
The code has been formatted using Ruff (ruff format homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

[n/a] Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

[n/a] The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
[n/a] New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
[n/a] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2024-10-10T20:10:10Z

Hey there @Galorhallen, mind taking a look at this pull request as it has been labeled with an integration (govee_light_local) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of govee_light_local can trigger bot actions by commenting:

@home-assistant close Closes the pull request.
@home-assistant rename Awesome new title Renames the pull request.
@home-assistant reopen Reopen the pull request.
@home-assistant unassign govee_light_local Removes the current integration label and assignees on the pull request, add the integration domain after the command.
@home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
@home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

mill1000 · 2024-10-10T20:30:59Z

homeassistant/components/govee_light_local/network.py

+from homeassistant.core import HomeAssistant
+
+
+async def _async_get_all_source_ipv4_ips(


I don't think we should re-invent the wheel here. The Network integration has async_get_enabled_source_ips which can easily be filtered down to IPv4 addresses.

@mill1000 the problem with async_get_enabled_source_ips is that it doesnt actually get all the IPs. There is some logic that decideds which NICs are enabled or not based on like mDNS hops or something. at least for me it was calculating my secondary nic as disabled. so i had to write a function that didn't filter out "disabled" devices.

Oh. Is your secondary NIC configured via System > Network?

it shows up in system network in the UI if that is what you are asking.

Hm.. that's quite a bit different looking than mine. Must be a HAOS vs container thing.

Here's mine where I manually enable a 2nd adapter. But I'm broadly assuming this is what "enables" another interface.

im running on supervised installer. i was looking for a UI like that....

just to make sure i wasn't crazy i tested using the async_get_enabled_source_ips and it doesn't return the IP for my secondary NIC.

so idk if this is just a me problem, and i dont know how else i could work around it, or if some other problem.

homeassistant/components/govee_light_local/coordinator.py

itewk · 2024-10-10T21:25:39Z

i have no idea what i would add for new tests here

Galorhallen · 2024-10-20T13:03:01Z

homeassistant/components/govee_light_local/_network.py

+        if adapter["ipv4"]:
+            addrs_ipv4 = [IPv4Address(ipv4["address"]) for ipv4 in adapter["ipv4"]]
+            sources.extend(addrs_ipv4)
+        if adapter["ipv6"]:


I think you can remove the if and the continue since it's the last instruction in the loop

I am happy to make that change but based on the previous threads it would seem not ideal for this PR to include the custom function for getting all IPv4 addresses that works around what seems to be an issue only for me that my additional NIC showes up as deactivated when using the stalk get enabled IPv4 addresses function.

so i was thinking i should re-do this PR without the custom function and ill leave the custom work around on my own version.

i was thinking maybe doing another PR that exposes a configuration option for listing the IPs want to listen on.

thoughts? should I leave this fucntion in here, or update to use the stalk get enabled IPs function?

I wouldn't rip out this code just on my behalf. It'd be great if a dev more familiar with the networking code could comment.

bryanyork · 2024-12-18T09:56:44Z

Prob not in scope, but can we extend this PR to support other network ranges? I have multiple networks via VLAN's and this integration doesn't work for me. In my case I have another subnet I would like to access, and not multiple network interfaces.

moutonnoireu · 2025-01-25T05:29:15Z

Anyone to merge this ? The Govee integration is not working for a lot of folks.

itewk · 2025-01-27T14:43:32Z

i think it was on me to break up the two parts of this. ill try and do that this week.

felixschndr · 2025-03-06T20:46:12Z

@itewk Any news on this? Thank you for your work! :)

moutonnoireu · 2025-04-09T05:15:31Z

Any news @itewk ? Still waiting for this :)

itewk · 2025-04-09T14:08:37Z

:( i know. im sorry. life.

this code is still working as is in my home. i guess @mill1000 and @Galorhallen what do you need to see to want to merge this in?

emontnemery · 2025-08-26T08:42:18Z

@itewk based on the test done by @jhollowe, do you think it's OK to merge the PR now, or do you need also a test with the modification suggested here: #128123 (comment)

Also, did you find the settings under /config/network? Can you enable the required NICs there yourself?

To find it via the UI, first click settings:

Then system:

And finally network:

Where you have the setting (note that the text is now improved compared to my previous screenshot):

itewk · 2025-08-26T16:06:35Z

@itewk based on the test done by @jhollowe, do you think it's OK to merge the PR now, or do you need also a test with the modification suggested here: #128123 (comment)

Yes. but i need to remove the use of the custom function that bypasses disabled NICS because of my own issue. Trying to do that now.

Also, did you find the settings under /config/network? Can you enable the required NICs there yourself?

My network settings look different, see: #128123 (comment)

itewk · 2025-08-26T16:51:30Z

@jhollowe i removed my personal workaround for my NIC problem. would you mind testing again?

itewk · 2025-08-26T19:17:03Z

rebased.

emontnemery · 2025-08-27T06:40:30Z

My network settings look different, see: #128123 (comment)

That screenshot is almost a year old though, does it still look the same?

itewk · 2025-08-27T13:43:01Z

My network settings look different, see: #128123 (comment)

That screenshot is almost a year old though, does it still look the same?

it looks the same. but now i have a warning that my install type is being depreciated. so i am going to have to change install types. sigh

emontnemery · 2025-08-27T14:18:33Z

@itewk your screenshot is of the first panel in the network settings, which allows configuring IP address etc.
If you scroll down, you should see the panel in my screenshot.

You may need to enable "advanced mode" in user settings.

itewk · 2025-08-27T14:23:41Z

@itewk your screenshot is of the first panel in the network settings, which allows configuring IP address etc. If you scroll down, you should see the panel in my screenshot.

You may need to enable "advanced mode" in user settings.

ooop. i see it. but it only lists one of my interfaces, it doesn't list both. so I don't know whats up with that. when i use my little cheat work around in code it definitely finds both, just one is listed as disabled.

itewk · 2025-08-27T14:25:16Z

@itewk your screenshot is of the first panel in the network settings, which allows configuring IP address etc. If you scroll down, you should see the panel in my screenshot.
You may need to enable "advanced mode" in user settings.

ooop. i see it. but it only lists one of my interfaces, it doesn't list both. so I don't know whats up with that. when i use my little cheat work around in code it definitely finds both, just one is listed as disabled.

nevermind! OMG! i had to uncheck autoconfigure and then both interfaces listed and then i was able to enable both! testing now!!!!

Currently govee_light_local can only discover and control devices on the primary NIC. This adds support for discovering and controlling devices on any NIC with an IPv4 address.

itewk · 2025-08-27T16:46:18Z

fixed issue where it was trying to listen on IPv6 addresses.

I have tested trhis locally and it is all working for me with no weird hacks. thanks @emontnemery

emontnemery

LGTM, thanks @itewk 👍

itewk · 2025-08-28T11:02:49Z

Wahooooo! Thanks!

abmantis · 2025-09-01T22:13:05Z

It seems that this change broke the integration. Fixes:

#151540
#151541

home-assistant bot added cla-signed Hacktoberfest integration: govee_light_local new-feature Quality Scale: No score labels Oct 10, 2024

itewk force-pushed the feature/govee-multi-nic branch 2 times, most recently from 3dd8d67 to dda17e3 Compare October 10, 2024 20:15

itewk marked this pull request as draft October 10, 2024 20:16

itewk force-pushed the feature/govee-multi-nic branch 2 times, most recently from fe63b99 to ad216d8 Compare October 10, 2024 20:29

mill1000 reviewed Oct 10, 2024

View reviewed changes

itewk force-pushed the feature/govee-multi-nic branch 8 times, most recently from 5731ea1 to 0e00b4b Compare October 10, 2024 21:20

itewk marked this pull request as ready for review October 10, 2024 21:26

MartinHjelmare changed the title ~~govee_light_local - add support for multiple NICs~~ Add multiple NICs in govee_light_local Oct 15, 2024

Galorhallen reviewed Oct 20, 2024

View reviewed changes

jhollowe mentioned this pull request Jul 17, 2025

In Home Assistant: "No devices found on the network" for h7021 Galorhallen/govee-local-api#172

Open

5 tasks

itewk force-pushed the feature/govee-multi-nic branch 4 times, most recently from cd8c611 to c5fa7f0 Compare August 26, 2025 16:48

itewk force-pushed the feature/govee-multi-nic branch 3 times, most recently from d211609 to 2867bb8 Compare August 26, 2025 19:11

bdraco mentioned this pull request Aug 27, 2025

Improve network adapter configuration discoverability home-assistant/frontend#26734

Merged

9 tasks

emontnemery added this to the 2025.9.0 milestone Aug 27, 2025

itewk force-pushed the feature/govee-multi-nic branch from 547dcff to fc02277 Compare August 27, 2025 16:44

govee_light_local - add support for multiple NICs

097c3fc

Currently govee_light_local can only discover and control devices on the primary NIC. This adds support for discovering and controlling devices on any NIC with an IPv4 address.

itewk force-pushed the feature/govee-multi-nic branch from fc02277 to 097c3fc Compare August 27, 2025 16:45

Merge branch 'dev' into feature/govee-multi-nic

882af93

emontnemery approved these changes Aug 28, 2025

View reviewed changes

emontnemery merged commit f4673f4 into home-assistant:dev Aug 28, 2025
34 checks passed

github-actions bot locked and limited conversation to collaborators Aug 29, 2025

frenck added the cherry-picked label Aug 29, 2025

		from homeassistant.core import HomeAssistant


		async def _async_get_all_source_ipv4_ips(

Uh oh!

Conversation

itewk commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed change

Type of change

Additional information

Checklist

Uh oh!

home-assistant bot commented Oct 10, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

itewk commented Oct 10, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

bryanyork commented Dec 18, 2024

Uh oh!

moutonnoireu commented Jan 25, 2025

Uh oh!

itewk commented Jan 27, 2025

Uh oh!

felixschndr commented Mar 6, 2025

Uh oh!

moutonnoireu commented Apr 9, 2025

Uh oh!

itewk commented Apr 9, 2025

Uh oh!

emontnemery commented Aug 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itewk commented Aug 26, 2025 • edited by emontnemery Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

itewk commented Aug 26, 2025

Uh oh!

itewk commented Aug 26, 2025

Uh oh!

emontnemery commented Aug 27, 2025

Uh oh!

itewk commented Aug 27, 2025

Uh oh!

emontnemery commented Aug 27, 2025

Uh oh!

itewk commented Aug 27, 2025

Uh oh!

itewk commented Aug 27, 2025

Uh oh!

itewk commented Aug 27, 2025

Uh oh!

emontnemery left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

itewk commented Aug 28, 2025

Uh oh!

abmantis commented Sep 1, 2025

Uh oh!

Reviewers

Assignees

Labels

itewk commented Oct 10, 2024 •

edited

Loading

emontnemery commented Aug 26, 2025 •

edited

Loading

itewk commented Aug 26, 2025 •

edited by emontnemery

Loading