Skip to content

release: 4.0.0#3695

Merged
curbengh merged 1 commit intohexojs:masterfrom
curbengh:4.0.0
Oct 16, 2019
Merged

release: 4.0.0#3695
curbengh merged 1 commit intohexojs:masterfrom
curbengh:4.0.0

Conversation

@curbengh
Copy link
Contributor

@curbengh curbengh commented Aug 30, 2019 •
edited
Loading

What does it do?

Closes #3508 , Closes #3611

How to test

git clone -b 4.0.0 https://github.com/curbengh/hexo.git
cd hexo
npm install
npm test

Pending deps (in hexo):

Pending deps' PR:

hexo-starter needs to be updated once this is merged but before publish.

@coveralls
Copy link

coveralls commented Aug 30, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 97.278% when pulling 6bf6e98 on curbengh:4.0.0 into 79bdc95 on hexojs:master.

This was referenced Aug 30, 2019
Closed
Closed
@SukkaW SukkaW added this to the v4.0.0 milestone Aug 30, 2019
@SukkaW
Copy link
Member

SukkaW commented Aug 30, 2019 •
edited
Loading

@curbengh
Copy link
Contributor Author

curbengh commented Sep 1, 2019 •
edited
Loading

Please only tick the checklist when the dep has been released (its release PR merged) and updated in hexo (update dep PR by dependabot merged).

Edit: I separated them into two checklists.

@yoshinorin
Copy link
Member

yoshinorin commented Sep 1, 2019

@curbengh @SukkaW
Now, I'm suggesting use project board https://github.com/orgs/hexojs/teams/core/discussions/6
If you have some opinion, please comment to https://github.com/orgs/hexojs/teams/core/discussions/6

@tomap
Copy link
Contributor

tomap commented Sep 7, 2019

arcchive & category published
not sure what to do on hexo-log & hexo-bunyan ?

@curbengh
Copy link
Contributor Author

curbengh commented Sep 7, 2019

I already emailed @NoahDragon about hexo-bunyan.

@curbengh curbengh mentioned this pull request Sep 26, 2019
Merged
@tomap
Copy link
Contributor

tomap commented Oct 1, 2019

I just merged hexojs/hexo-starter@beb727c
However, it is directly used by hexo init command
So, if we stay like that, hexo init becomes compatible only with nodejs >= 8
Shall we rollback?

@SukkaW
Copy link
Member

SukkaW commented Oct 1, 2019

@tomap

Since hexojs/site#1026 has already be merged, I think it will be fine.

@curbengh
Copy link
Contributor Author

curbengh commented Oct 2, 2019

Besides, all essential plugins (which drop node 6) are already published.

@curbengh curbengh marked this pull request as ready for review October 2, 2019 07:50
@curbengh
Copy link
Contributor Author

curbengh commented Oct 8, 2019 •
edited
Loading

All blocking bugs/PRs have been fixed/merged, so I think this is ready.

Rebased to make sure.

@curbengh curbengh requested a review from a team October 8, 2019 01:28
@SukkaW
Copy link
Member

SukkaW commented Oct 8, 2019

@curbengh Pending document update, there are some PRs are still in draft.

@curbengh
Copy link
Contributor Author

curbengh commented Oct 8, 2019

you mean my PRs? Those are actually ready, I set it to draft to prevent being mistakenly merged (before v4).

Maybe we should prepare a release note in the meantime as well, I'll prepare it in these few days.

SukkaW
SukkaW previously approved these changes Oct 9, 2019
View reviewed changes
@SukkaW SukkaW requested review from segayuu, tomap and yoshinorin October 9, 2019 13:43
@SukkaW
Copy link
Member

SukkaW commented Oct 9, 2019

We should review all PRs listed in Post v4 project, make sure they will be fine to merged immediately after Hexo v4 released.

@curbengh curbengh mentioned this pull request Oct 10, 2019
Merged
1 task
yoshinorin
yoshinorin previously approved these changes Oct 10, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@curbengh
Copy link
Contributor Author

curbengh commented Oct 11, 2019

Blocking bug #3758

@curbengh curbengh mentioned this pull request Oct 13, 2019
Merged
@curbengh
Copy link
Contributor Author

curbengh commented Oct 13, 2019 •
edited
Loading

I would like to include hexojs/hexo-util#110, but if the fix is not right (i.e. too ugly), I don't mind postponing it.

Edit: Postponing hexojs/hexo-util#110.

This is ready.

#3765

@curbengh curbengh removed the request for review from tomap October 13, 2019 23:41
@curbengh curbengh requested review from a team and removed request for segayuu October 13, 2019 23:41
@curbengh curbengh dismissed stale reviews from yoshinorin and SukkaW via 6bf6e98 October 13, 2019 23:44
@curbengh curbengh requested review from SukkaW and yoshinorin October 13, 2019 23:45
@curbengh
Copy link
Contributor Author

curbengh commented Oct 14, 2019

Ready

yoshinorin
yoshinorin approved these changes Oct 15, 2019
View reviewed changes
Copy link
Member

@yoshinorin yoshinorin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's OK except for a few documentations :)

@yoshinorin yoshinorin requested review from segayuu and tomap October 15, 2019 11:32
@curbengh curbengh merged commit 9662366 into hexojs:master Oct 16, 2019
@curbengh curbengh deleted the 4.0.0 branch October 16, 2019 00:19
@curbengh
Copy link
Contributor Author

curbengh commented Oct 16, 2019 •
edited
Loading

https://www.npmjs.com/package/hexo/v/4.0.0

I also cleaned up the tags,

$ npm dist-tag rm hexo@1.2.4 stable
$ npm dist-tag rm hexo@3.2.0-beta.2 beta

@NoahDragon
Copy link
Member

NoahDragon commented Oct 19, 2019

Congrats, it is a really big milestone after Hexo 3. It took four years to achieve this. Thank you all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yoshinorin yoshinorin yoshinorin approved these changes

@SukkaW SukkaW SukkaW approved these changes

@segayuu segayuu Awaiting requested review from segayuu

@tomap tomap Awaiting requested review from tomap

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v4.0.0

Development

Successfully merging this pull request may close these issues.

Update hexo-front-matter Drop NodeJs 6 support & Require NodeJs >= 8.6

6 participants

@curbengh @coveralls @SukkaW @yoshinorin @tomap @NoahDragon