Skip to content

chore(deps): update warehouse requirement from ^2.2.0 to ^3.0.0#3736

Merged
yoshinorin merged 1 commit intohexojs:masterfrom
yoshinorin:warehouse-3
Oct 1, 2019
Merged

chore(deps): update warehouse requirement from ^2.2.0 to ^3.0.0#3736
yoshinorin merged 1 commit intohexojs:masterfrom
yoshinorin:warehouse-3

Conversation

@yoshinorin
Copy link
Member

@yoshinorin yoshinorin commented Sep 28, 2019

@coveralls
Copy link

coveralls commented Sep 28, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.002%) to 97.277% when pulling ed64a7d on YoshinoriN:warehouse-3 into 58a4882 on hexojs:master.

@yoshinorin yoshinorin mentioned this pull request Sep 28, 2019
Closed
@yoshinorin yoshinorin added the dependencies Pull requests that update a dependency file label Sep 28, 2019
@yoshinorin
Copy link
Member Author

yoshinorin commented Sep 28, 2019 •
edited
Loading

Test failure caused by this commit

@yoshinorin yoshinorin mentioned this pull request Sep 28, 2019
Merged
@yoshinorin
Copy link
Member Author

yoshinorin commented Sep 28, 2019

Caused by this change.

Now I'm asking it to @segayuu. We might have to release the warehouse v3.0.1

This was referenced Sep 28, 2019
Closed
Merged
@curbengh
Copy link
Contributor

curbengh commented Sep 29, 2019

My guess is that promise might have resolved/rejected prematurely,

hexo/test/scripts/box/box.js

Lines 129 to 149 in 6cda202

it('process() - mtime changed', () => {
const box = newBox('test');
const name = 'a.txt';
const path = pathFn.join(box.base, name);
const cacheId = 'test/' + name;
const processor = sinon.spy();
box.addProcessor(processor);
return Promise.all([
fs.writeFile(path, 'a'),
box.Cache.insert({
_id: cacheId,
modified: 0
})
]).then(() => box.process()).then(() => {
const file = processor.args[0][0];
file.type.should.eql('update');
file.path.should.eql(name);
}).finally(() => fs.rmdir(box.base));
});

what about,

return Promise.all[fs.writeFile(path, 'a')].then(() => {
      box.Cache.insert({
        _id: cacheId,
        modified: 0
      })
    ])}

hexo/test/scripts/box/box.js

Lines 151 to 168 in 6cda202

it('process() - hash changed', () => {
const box = newBox('test');
const name = 'a.txt';
const path = pathFn.join(box.base, name);
const cacheId = 'test/' + name;
const processor = sinon.spy();
box.addProcessor(processor);
return fs.writeFile(path, 'a').then(() => fs.stat(path)).then(stats => box.Cache.insert({
_id: cacheId,
modified: stats.mtime
})).then(() => box.process()).then(() => {
const file = processor.args[0][0];
file.type.should.eql('update');
file.path.should.eql(name);
}).finally(() => fs.rmdir(box.base));
}); 

return Promise.all[fs.writeFile(path, 'a')].then

@yoshinorin yoshinorin mentioned this pull request Sep 29, 2019
Merged
2 tasks
@yoshinorin
Copy link
Member Author

yoshinorin commented Sep 29, 2019 •
edited
Loading

@curbengh
Thanks for your support 😃
But, it seems caused by modified fields type. The modified field seems should use UnixTime but current source code mixed UnixTime and ISO8601

I create new PR (#3739)

@yoshinorin
Copy link
Member Author

yoshinorin commented Sep 30, 2019 •
edited
Loading

Today, I wrote my blog using by this branch. It seems no-problem :)

curbengh
curbengh approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@curbengh curbengh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@yoshinorin yoshinorin merged commit bc7740f into hexojs:master Oct 1, 2019
@yoshinorin yoshinorin deleted the warehouse-3 branch October 1, 2019 14:09
@dailyrandomphoto dailyrandomphoto mentioned this pull request Oct 10, 2019
Closed
4 tasks
thom4parisot pushed a commit to thom4parisot/hexo that referenced this pull request Jan 17, 2020
@yoshinorin
chore(deps): update warehouse requirement from ^2.2.0 to ^3.0.0 (hexo…
c5fa9d5 
…js#3736)
@snyk-bot snyk-bot mentioned this pull request Mar 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curbengh curbengh curbengh approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yoshinorin @coveralls @curbengh