chore: update to hexo-util@1.0.1 and hexo-renderer-marked@2.0.0#3646
chore: update to hexo-util@1.0.1 and hexo-renderer-marked@2.0.0#3646yoshinorin merged 9 commits intohexojs:masterfrom
Conversation
|
I can confirm the issue is caused by hexo-util@1.0.0-rc1 alone. hexo-util@1.0.0-rc1 vs hexo-util@0.6.3: 41c86,88
< "bluebird": "^3.4.0",
---
>
> "bluebird": "^3.5.2",
>
43,46c90,104
< "cross-spawn": "^4.0.0",
< "highlight.js": "^9.4.0",
< "html-entities": "^1.2.0",
< "striptags": "^2.1.1"
---
>
> "cross-spawn": "^6.0.5",
>
> "highlight.js": "^9.13.1",
>
> "html-entities": "^1.2.1",
>
> "striptags": "^3.1.1"
> Possible causes: cross-spawn, highlight.js and striptags. I'm testing each dep. Issue not resolved after downgrading deps. Looking through the hexo-util's history, the failure starts from this commit (hexojs/hexo-util@38933b6#diff-e8acc63b1e238f3255c900eed37254b8). The commit allows empty attribute to retain (e.g. Edit: Still looking for cause of weird line numbering. Line numbering issue is caused by hexojs/hexo-util@ed5cb6e#diff-e8acc63b1e238f3255c900eed37254b8 Somehow firstLine is treated as a string, thus causing string concatenation, instead of being computed. Submitted fix PR (hexojs/hexo-util#67). |
|
There is something wrong with this PR/branch, works, but not "hexo": "tomap/hexo#feature/PackageRCCaused by hexo-util@1.0.0-rc2, no issue after downgraded to hexo-util@1.0.0-rc1. Probably related to hexojs/hexo-util#57 (comment). PR fix hexojs/hexo-util#69 |
|
Somehow hexo-util is still outdated. Testing... Pass 🎊 |
|
Pending hexojs/hexo-renderer-marked#107 |
|
Pending hexojs/hexo-renderer-marked#108 |
yoshinorin
left a comment
There was a problem hiding this comment.
Tag cloud color class should migrate to hexo-util.
|
eea2134 fixes #3656, but pending hexojs/hexo-util#75 hexojs/hexo-util#75 merged, pending to be published hexojs/hexo-util#76. Published https://www.npmjs.com/package/hexo-util/v/1.0.1 to include hexojs/hexo-util#75 @yoshinorin I think it's ready. |
yoshinorin
left a comment
There was a problem hiding this comment.
@curbengh
Sorry so late. LGTM
I updated both packages to RC versions, and there are a few tests to investigate after the update