fix: prevent firstLine being parsed as a string#67
Merged
curbengh merged 1 commit intohexojs:masterfrom Aug 7, 2019
Merged
Conversation
Contributor
Author
|
It's not supposed to be parsed as a string though, const firstLine = 1;
const i = 2;
const check = `<span class="line">${firstLine + i}</span><br>`
console.log(check)works as expected. |
2 similar comments
tomap
approved these changes
Aug 7, 2019
Contributor
tomap
left a comment
There was a problem hiding this comment.
LGTM, but we still don't fully understand the cause of this issue.
Maybe we don't need to :)
Contributor
Author
|
My guess is that hexo parse output of hexo-util as string, maybe too aggressively. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firstLine variable sometimes can be parsed as a string.
let say,
firstLine = 1;firstLine + 3can results in13, instead of expected4.See hexojs/hexo#3646