Return group memberships of entity during read#3526
Merged
vishalnayak merged 9 commits intomasterfrom Nov 6, 2017
Merged
Conversation
chrishoffman
reviewed
Nov 3, 2017
Contributor
chrishoffman
left a comment
There was a problem hiding this comment.
This looks good. I wonder if there will be any way to expand and flatten the group hierarchy to see all groups they are a member of, even if they are nested.
Contributor
Author
|
@chrishoffman The API returns segregated sets of group membership data now. |
chrishoffman
previously approved these changes
Nov 3, 2017
vault/identity_store_entities.go
Outdated
| respData["aliases"] = aliasesToReturn | ||
|
|
||
| // Fetch the groups this entity belongs to and return their identifiers | ||
| groups, impliedGroups, err := i.groupsByEntityID(entity.ID) |
Contributor
There was a problem hiding this comment.
minor: Can we match the external names with the internal variable names? implied vs inherited
jefferai
previously approved these changes
Nov 6, 2017
Member
jefferai
left a comment
There was a problem hiding this comment.
LGTM with Chris' comment addressed.
99b58a3
chrishoffman
pushed a commit
that referenced
this pull request
Nov 7, 2017
* oss/master: (30 commits) Handle 'not supplied' case for field type TypeNameString (#3546) Fix deprecated cassandra backend tests (#3543) changelog++ auth/aws: Make disallow_reauthentication and allow_instance_migration mutually exclusive (#3291) changelog++ More Mount Conflict Detection (#2919) Fix swallowed errors in TestRollbackManager_Join() (#3327) changelog++ added AWS enpoint handling (#3416) Seal wrap all root tokens and their leases (#3540) Return group memberships of entity during read (#3526) Add note on support for using rec keys on /sys/rekey (#3517) Add third party tools list to website (#3488) Minor client refactoring (#3539) changelog++ Add PKCS8 marshaling to PKI (#3518) Update SSH list roles docs (#3536) Update gocql dep changelog++ Return role info for each role on pathRoleList (#3532) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.