Backport of docs: add known issues section to 1.9.x upgrade guide into release/1.9.x#13713
Conversation
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes 3 out of 4 committers have signed the CLA.
temp seems not to be a GitHub user. Have you signed the CLA already but the status is still pending? Recheck it. |
|
@calvn I think you'll need to update the docs-nav-data.json file too? But I'm worried about the rest of the upgrade guides on this branch now, which I think are all the .0 versions. |
|
Manually? I think? We might not be able to cherry pick them but my git-skills are also definitely not top-notch. I would do it manually because that would be the fastest one-time solution for me, but it might be worth trying to find out if there is a better way. |
f980538 to
0663dce
Compare
|
I ended up doing an ordered cherry-pick based off https://github.com/hashicorp/vault/commits/main/website/content/docs/upgrading/upgrade-to-1.9.x.mdx to bring the files in, which also takes care of removing It's all piggybacked into this one PR which is not great but makes it way simpler (vs 3 different backports) |
mladlow
left a comment
There was a problem hiding this comment.
I'm not sure whether you want the newer content in identity.mdx and the 1.9 upgrade guide from main?
There was a problem hiding this comment.
This file also has different content in main.
There was a problem hiding this comment.
Thanks for catching that, I might have messed up during merge conflict... I'll fix this up.
There was a problem hiding this comment.
Updated, should be good now!
* Add entity-alias behavior change to docs * Add upgrade note about entity-alias mapping change * Rename 1.7-9 upgrade pages, shuffle upgrade note position * Update website/content/partials/entity-alias-mapping.mdx Co-authored-by: Meggie <meggie@hashicorp.com> * Add incorrect policy issue to the docs * Add example about entity-alias restriction Co-authored-by: Meggie <meggie@hashicorp.com>
* docs: add known issues section to 1.9.x upgrade guide * minor rephrasing on oidc known issue * use relative references for URLs * Update website/content/docs/upgrading/upgrade-to-1.9.x.mdx Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com> * update known issues section for id token Co-authored-by: Tom Proctor <tomhjp@users.noreply.github.com>
0663dce to
8976ca8
Compare
mladlow
left a comment
There was a problem hiding this comment.
Thanks for the extra digging!
So one problem is that I'm still not sure how to get the CLA to realize that this account has signed it...
|
I'm pretty sure it's due to how backport-assistant makes that no-op commit. Linked you the source offline. |
| "path": "upgrading/upgrade-to-1.9.0", | ||
| "title": "Upgrade to 1.9.x", | ||
| "path": "upgrading/upgrade-to-1.9.x", | ||
| "hidden": true |
There was a problem hiding this comment.
@mladlow I wonder if we should remove the hidden attribute. Otherwise, the docs might not show when 1.9.x is versioned.
There was a problem hiding this comment.
I might leave it out of this PR since I want to keep the result from the diff the same from the resulting 3 cherry-picks that I did.
hashicorp#13713) Signed-off-by: Ryan Cragun <me@ryan.ec> Co-authored-by: Ryan Cragun <me@ryan.ec>
Backport
This PR is auto-generated from #13662 to be assessed for backporting due to the inclusion of the label backport/website.
WARNING automatic cherry-pick of commits failed. Commits will require human attention.
The below text is copied from the body of the original PR.
Adds a "Known Issues" section to our 1.9.x upgrade guide, and includes a note about a panic that can be encountered on Vault installations that are using the ID token backend and have named keys created.