OSS side of the managed key interfaces#13699
Merged
Conversation
| @@ -0,0 +1,47 @@ | |||
| //go:build hsm | |||
Contributor
There was a problem hiding this comment.
Not sure why this build tag exists within OSS? With this the test will never run within this build so maybe the test doesn't belong within OSS or we need to remove this build tag?
Collaborator
Author
There was a problem hiding this comment.
You're right, none of those files belong on OSS. I've removed them. On the ENT side I think we still need the hsm build tag because PKCS11 code doesn't get built except on the HSM build, and the test references the pkcs11 managed key struct.
pull bot
pushed a commit
to NOUIY/vault
that referenced
this pull request
Apr 7, 2026
hashicorp#13713) Signed-off-by: Ryan Cragun <me@ryan.ec> Co-authored-by: Ryan Cragun <me@ryan.ec>
pbromb
pushed a commit
to pbromb/vault
that referenced
this pull request
Apr 13, 2026
hashicorp#13716) (hashicorp#13726) Signed-off-by: Ryan Cragun <me@ryan.ec> Co-authored-by: Ryan Cragun <me@ryan.ec>
MochaCaffe
pushed a commit
to kosmos-education/vault
that referenced
this pull request
Apr 15, 2026
hashicorp#13717) (hashicorp#13723) Signed-off-by: Ryan Cragun <me@ryan.ec> Co-authored-by: Ryan Cragun <me@ryan.ec>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.