Allow accepting image for the members in OpenStack builder#8931
Merged
nywilken merged 3 commits intohashicorp:masterfrom Mar 23, 2020
Merged
Allow accepting image for the members in OpenStack builder#8931nywilken merged 3 commits intohashicorp:masterfrom
nywilken merged 3 commits intohashicorp:masterfrom
Conversation
Codecov Report
|
SwampDragons
suggested changes
Mar 23, 2020
Contributor
SwampDragons
left a comment
There was a problem hiding this comment.
I think the code looks fine, just needs a little bit more clarity in the documentation. Thanks for this contribution!
builder/openstack/image_config.go
Outdated
| // usually a project (also called the "tenant") with whom the image is | ||
| // shared. | ||
| ImageMembers []string `mapstructure:"image_members" required:"false"` | ||
| // True to perform the image accept so the member can see the image in his |
Contributor
There was a problem hiding this comment.
I'd like to see a bit more detail here, including the fact that for it to work your build user needs to have special privileges. Also, make it clear here that by default the value is "false"
Contributor
Author
|
I just updated the documentation with those changes. If you think there're other things that needs to change, let me know. Thanks! |
builder/openstack/image_config.go
Outdated
| // usually a project (also called the "tenant") with whom the image is | ||
| // shared. | ||
| ImageMembers []string `mapstructure:"image_members" required:"false"` | ||
| // True to perform the image accept so the member can see the image in his |
Contributor
There was a problem hiding this comment.
Suggested change
| // True to perform the image accept so the member can see the image in his | |
| // When true, perform the image accept so the member can see the image in their |
builder/openstack/image_config.go
Outdated
| // shared. | ||
| ImageMembers []string `mapstructure:"image_members" required:"false"` | ||
| // True to perform the image accept so the member can see the image in his | ||
| // project. This requires an user with priveleges both in the build project and |
Contributor
There was a problem hiding this comment.
Suggested change
| // project. This requires an user with priveleges both in the build project and | |
| // project. This requires a user with priveleges both in the build project and |
SwampDragons
suggested changes
Mar 23, 2020
Contributor
SwampDragons
left a comment
There was a problem hiding this comment.
Made a couple of grammatical suggestions; otherwise it looks good now. Thanks for the fast turnaround.
922883f to
673b5a7
Compare
SwampDragons
approved these changes
Mar 23, 2020
nywilken
added a commit
that referenced
this pull request
Mar 27, 2020
…atching Before change ``` 413e19b Merge pull request #8942 from desolatorxxl/google-fix-ssh-keys-metadata b81800d Merge pull request #8935 from zaventh/feature/start-on-boot 9486316 Merge pull request #8922 from hashicorp/f-vsphere_iso-export-ovf-options 56aebbe Merge pull request #8920 from rhencke/patch-1 d068430 make sure locals are evaluated only once variables are + test this (#8918) 3dae5df Merge pull request #8905 from hashicorp/fix_8493 811a730 Merge pull request #8907 from hashicorp/fix_8428 fa49d21 Merge pull request #8906 from hashicorp/fix_8904 23f5603 Merge pull request #8889 from hashicorp/hcl2_singular_blocks dc9259f Merge pull request #8892 from zaventh/feature/vga-adapter fc35f02 Merge pull request #8890 from hashicorp/fix_8880 7972ab7 Merge pull request #8735 from hashicorp/fix_plugin_loading 890d7b2 Merge pull request #8875 from hashicorp/fix_8812 e94ff70 Merge pull request #8883 from hashicorp/fix_8835 9075b80 Merge pull request #8891 from rhencke/patch-1 6477d8a Merge pull request #8882 from hashicorp/fix-var-file-hcl 6008f91 Merge pull request #8847 from takaishi/support-keyboard-interactive 5604561 Merge pull request #8877 from paulcichonski/remote-esxi-bastion 698f744 Merge pull request #8887 from hashicorp/untangle_ssh_docs_from_aws aeedc9a Merge pull request #8879 from mbrancato/specify_keyvault_sku 5365fda Merge pull request #8884 from hashicorp/fix_codecov_config 4bd7b14 Merge pull request #8732 from jhawk28/reorder_cdrom_drive 072a71b Merge pull request #8863 from hashicorp/update_go-cty_regex 8a1caaa Merge pull request #8837 from hashicorp/fix_8730 7873cab Merge pull request #8858 from hashicorp/fix_8791 7e382d0 Merge pull request #8828 from mvitaly/fix_8816 8832b3e Merge pull request #8787 from jhawk28/vsphere_iso_multiple_disks 5281740 Merge pull request #8831 from rjhornsby/master e35a872 Merge pull request #8830 from hashicorp/d-var-file-hcl2-not-yet ``` After change ``` ⇶ git log v1.5.4...v1.5.5 --first-parent --oneline --grep="Merge pull request #[0-9]\+" --grep="(#[0-9]\+)$" 413e19b Merge pull request #8942 from desolatorxxl/google-fix-ssh-keys-metadata c387dc2 builder/vsphere-clone: Find the vm within the folder (#8938) b17b211 Add cleanup_remote_cache config option to vmware-iso (#8917) e6368b9 Fix azure winrm_password attribution and allow to set winrm_username (#8928) fcf10e9 Replace Amazon with Outscale for OSC BSU doc (#8944) 9240fb7 Fix typo in title (#8943) 2c6f096 Allow accepting image for the members in OpenStack builder (#8931) b81800d Merge pull request #8935 from zaventh/feature/start-on-boot daffd9c CONTRIBUTING: Update documentation for linting on Travis (#8933) 3a9d356 golangci-lint: Update --new-from-rev option to check only newly added commits (#8923) 97d797d Fix small typos in osc-bsuvolume.html.md (#8926) 9486316 Merge pull request #8922 from hashicorp/f-vsphere_iso-export-ovf-options 56aebbe Merge pull request #8920 from rhencke/patch-1 99b0b98 Add ovf export capability to vsphere builders (#8764) d068430 make sure locals are evaluated only once variables are + test this (#8918) ad8dafa HCL: add tests and fixes around var-file and var args (#8914) 7979ab0 Add after_n_builds to codecov.yml (#8913) 3dae5df Merge pull request #8905 from hashicorp/fix_8493 811a730 Merge pull request #8907 from hashicorp/fix_8428 fa49d21 Merge pull request #8906 from hashicorp/fix_8904 b94937c Update provisioner_test.go (#8900) 2319521 Add iso config test for checksum from file specific case (#8897) 23f5603 Merge pull request #8889 from hashicorp/hcl2_singular_blocks dc9259f Merge pull request #8892 from zaventh/feature/vga-adapter 690bf71 Add Codecov badge and remove report style (#8896) fc35f02 Merge pull request #8890 from hashicorp/fix_8880 7972ab7 Merge pull request #8735 from hashicorp/fix_plugin_loading 890d7b2 Merge pull request #8875 from hashicorp/fix_8812 e94ff70 Merge pull request #8883 from hashicorp/fix_8835 ```
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, in openstack you can share an image for some members setting them in the image_members parameter, but then, for the members to see it on their proyect, you need to share the image ID with them, and they need to perform an accept action. This is documented here
This PR adds a configuration parameter image_auto_accept_members that performs this action after sharing the image with those members. This needs a user with special privileges but if you use it on your image pipeline, this could simplify it.