Skip to content

testling support#234

Merged
hueniverse merged 2 commits intohapijs:masterfrom
lkptrzk:testling-ci
Apr 17, 2014
Merged

testling support#234
hueniverse merged 2 commits intohapijs:masterfrom
lkptrzk:testling-ci

Conversation

@lkptrzk
Copy link
Contributor

@lkptrzk lkptrzk commented Apr 9, 2014

To close #233.

Just following the quick start guide. Only thing you'll need to do is add the web hook.

Unfortunately it looks like the build is failing on my fork, but that matches the output I got running locally on my mac opening the tests in chrome:

~/git/joi> browserify test/*.js | testling -u # -u flag prints url to visit in browser
http://localhost:50349/__testling?show=true

not ok 1 Error: Uncaught TypeError: Object #<Object> has no method 'createDomain' on line 15420
^C~/git/joi> browserify test/*.js | grep Domain
var Domain = require('domain');
    var baseDomain = Domain.createDomain();
    var scopeDomain = Domain.createDomain();
            baseDomain.exit();
            scopeDomain.removeAllListeners();
    scopeDomain.once('error', function (err) {
    baseDomain.enter();
    scopeDomain.enter();

Looks like @substack's already on fixing that via this pull request in the browserify shim for domain.

@lkptrzk
Copy link
Contributor Author

lkptrzk commented Apr 9, 2014

Was going to try to add some sort of make test-browserify but wanted to hear back on #235 first.

@hueniverse hueniverse added the test label Apr 9, 2014
@hueniverse hueniverse self-assigned this Apr 9, 2014
hueniverse pushed a commit that referenced this pull request Apr 17, 2014
Merge pull request #234 from lkptrzk/testling-ci
d1215f3 
testling support
@hueniverse hueniverse merged commit d1215f3 into hapijs:master Apr 17, 2014
@hueniverse hueniverse added this to the 4.0.0 milestone Apr 17, 2014
@balupton
Copy link

balupton commented Jun 7, 2014

Just pushed substacks changes to the shim

@hueniverse
Copy link
Contributor

hueniverse commented Jun 8, 2014

@balupton what does that mean? Can we fix this so that the readme doesn't look so awful?

@balupton
Copy link

balupton commented Jun 8, 2014

@heuniverse

Sorry for the ambiguity, this was in relation to:

Looks like @substack's already on fixing that via this pull request in the browserify shim for domain.

Which is now merged in and published.

@hueniverse
Copy link
Contributor

hueniverse commented Jun 8, 2014

@balupton can you help get the testling badge working?

@lock
Copy link

lock bot commented Jan 9, 2020

This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@hueniverse hueniverse

Labels

test Test or coverage

Projects

None yet

Milestone

4.0.0

Development

Successfully merging this pull request may close these issues.

Add testling-ci badges

3 participants

@lkptrzk @balupton @hueniverse