Remove Makefile, add npm scripts#235
Closed
lkptrzk wants to merge 1 commit intohapijs:masterfrom
lkptrzk:rm-makefile
Closed
Remove Makefile, add npm scripts#235lkptrzk wants to merge 1 commit intohapijs:masterfrom lkptrzk:rm-makefile
lkptrzk wants to merge 1 commit intohapijs:masterfrom
lkptrzk:rm-makefile
Conversation
Merged
Contributor
|
Whatever we do has to be identical across all spumko modules. We will still want the makefile for the other types of tests. Also, looks like your change isn't solving testing on Windows with the coverage issue. |
|
This thread has been automatically locked due to inactivity. Please open a new issue for related bugs or questions following the new issue template instructions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Couldn't find a reason/issue explaining why the Makefile stuff wasn't just in package.json.
Instead of
make test-covit would now be run withnpm run test-cov.Runs fine on my mac, but for some reason test-cov reports 0% on my windows 8 vm in git bash:
But at least
npm testruns okay!makeisn't in git bash on windows by default and installing anything in any pseudo bash environment in windows is hell.Figured I'd submit a PR even if it's not wanted so the reason's documented somewhere.