Extracted functions to static methods#345
Merged
Nyholm merged 2 commits intoguzzle:1.xfrom Sep 19, 2020
GrahamCampbell:no-functions
Merged
Extracted functions to static methods#345Nyholm merged 2 commits intoguzzle:1.xfrom GrahamCampbell:no-functions
Nyholm merged 2 commits intoguzzle:1.xfrom
GrahamCampbell:no-functions
Conversation
9 tasks
Member
Author
Nyholm
requested changes
Sep 19, 2020
Member
Nyholm
left a comment
There was a problem hiding this comment.
Thank you. I like this.
I just had some minors. After that Im 👍
| * | ||
| * @return array | ||
| */ | ||
| public static function parseMessage($message) |
Member
There was a problem hiding this comment.
This should be internal as _parse_message.
| * | ||
| * @return array | ||
| */ | ||
| public static function caselessRemove($keys, array $data) |
Member
There was a problem hiding this comment.
This should be marked as internal too.
| * | ||
| * @return string | ||
| */ | ||
| public static function parseRequestUri($path, array $headers) |
Member
Author
|
🚀 |
Closed
bbrala
referenced
this pull request
in bbrala/psr7
Nov 24, 2020
* Extracted functions to static methods * Fixed typo in README
albe
added a commit
to neos/neos-development-collection
that referenced
this pull request
Jul 1, 2021
daniellienert
pushed a commit
to neos/neos-development-collection
that referenced
this pull request
Jul 15, 2021
daniellienert
pushed a commit
to neos/neos-development-collection
that referenced
this pull request
Jul 15, 2021
neos-bot
pushed a commit
to neos/fusion
that referenced
this pull request
Jul 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR pairs with guzzle/guzzle#2712. After this is merged, we can tag 1.7.0.
TODO:
Mappings:
strMessage::toStringuri_forUtils::uriForstream_forUtils::streamForparse_headerHeader::parsenormalize_headerHeader::normalizemodify_requestUtils::modifyRequestrewind_bodyMessage::rewindBodytry_fopenUtils::tryFopencopy_to_stringUtils::copyToStringcopy_to_streamUtils::copyToStreamhashUtils::hashreadlineUtils::readLineparse_requestMessage::parseRequestparse_responseMessage::parseResponseparse_queryQuery::parsebuild_queryQuery::buildmimetype_from_filenameMimeType::fromFilenamemimetype_from_extensionMimeType::fromExtension_parse_messageMessage::parseMessage_parse_request_uriMessage::parseRequestUriget_message_body_summaryMessage::bodySummary_caseless_removeUtils::caselessRemoveNB The overall idea of these changes was approved by the original author, Michael: guzzle/promises#108.