Skip to content

[2.0] Started work on v2#108

Closed
GrahamCampbell wants to merge 1 commit intoguzzle:masterfrom
GrahamCampbell:next-gen
Closed

[2.0] Started work on v2#108
GrahamCampbell wants to merge 1 commit intoguzzle:masterfrom
GrahamCampbell:next-gen

Conversation

@GrahamCampbell
Copy link
Copy Markdown
Member

PHP 7.2+, with the same changes as I proposed for Guzzle 7, avoiding calling the helper functions within the core code, to mitigate global package installation issues.

@mtdowling
Copy link
Copy Markdown
Member

Good ideas!

A random idea I had that I never had time to pursue was whether or not this library could move towards a thread-safe solution. As of right now, all promises mutate a global queue and can't be easily used with libraries like pthreads (anecdotally basing this on issues I've seen over the last few years).

@GrahamCampbell
Copy link
Copy Markdown
Member Author

I am going to pull out the Utils class changes so we can add this in 1.4.0.

@GrahamCampbell
Copy link
Copy Markdown
Member Author

I am going to implement the Utils class for 1.4.0, and deprecate the global functions. That way Guzzle 7.1.0 can use it.

@GrahamCampbell
Copy link
Copy Markdown
Member Author

Regarding other changes, like dropping old PHP and adding typing, that can be addressed later down the line, when we are actually ready to start work on 2.0. I want to prioritise fixing the global functions problem on the 1.x series, so we can get that out sooner than 2.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants