Add Bazel 9 support for //third_party by smolkaj · Pull Request #41757 · grpc/grpc

smolkaj · 2026-03-01T02:07:49Z

Why

Bazel 9 is out and gRPC's BCR entry currently doesn't build under it
(tracked in #41697). This PR fixes the last remaining blocker.

bazel/cython_library.bzl was already fixed in this repo. The only
remaining issue is third_party/address_sorting/address_sorting.bzl,
which calls native.cc_library without a load() — a hard error in
Bazel 9, which removed the autoload of native C++ rules.

Changes

third_party/address_sorting/address_sorting.bzl: load cc_library
explicitly (consistent with e.g. bazel/cc_grpc_library.bzl) instead
of using native.cc_library

For maintainers

Please add the release notes: no label (Mergeable requirement) and
approve the check_bzl_deps workflow run.

linux-foundation-easycla · 2026-03-01T02:07:55Z

The committers listed above are authorized under a signed CLA.

✅ login: smolkaj / name: Steffen Smolka (56a2dbe, b9644ec, ebe04bc)

- Replace native.cc_library with a loaded cc_library in third_party/address_sorting/address_sorting.bzl. In Bazel 9, native C++ rules are no longer autoloaded into the global namespace. - Bump .bazelversion to 9.0.0. Signed-off-by: Steffen Smolka <steffen.smolka@gmail.com>

smolkaj · 2026-03-09T16:58:33Z

Gentle reminder, could I get a review/merge?

smolkaj · 2026-03-09T16:58:42Z

@yuanweiz

yuanweiz · 2026-03-09T20:38:47Z

@yuanweiz

Can you revert the .bazelversion change? We don't fully support bazel 9 yet (with some native bits hanging around and bzlmod support unfinished). The address_sorting change looks fine.

yuanweiz · 2026-03-09T20:40:20Z

If the goal is to fix bcr we can add a separate patch file under .bcr, since our BCR presubmit only builds a small subset of targets.

smolkaj · 2026-03-10T04:00:50Z

@yuanweiz

Can you revert the .bazelversion change? We don't fully support bazel 9 yet (with some native bits hanging around and bzlmod support unfinished). The address_sorting change looks fine.

Done.

FWIW, this builds fine on my machine with Bazel 9.

smolkaj · 2026-03-10T04:02:16Z

If the goal is to fix bcr we can add a separate patch file under .bcr, since our BCR presubmit only builds a small subset of targets.

Done: bazelbuild/bazel-central-registry#7749

yuanweiz

Thanks for this change!

smolkaj · 2026-03-10T18:43:09Z

Thanks for the review!

anything else I need to do for this to get merged, or will this be handled by you/others?

yuanweiz · 2026-03-10T21:48:23Z

I'm triggering the CI, once it's passed I'll have a repo admin merge it.

yuanweiz · 2026-03-11T16:41:42Z

@markdroth this looks good. ~~Could you merge it when you have time?~~ I'm checking our copybara setup to confirm whether this change affects google3 counterpart

yuanweiz · 2026-03-11T16:49:43Z

I saw this error message that doesn't match what I see on github UI.

0311 09:41:57.486 VERBOSE: PROFILE:   4010 //copybara/8b8f06cc-5064-4a46-95ef-4aa73771837e_4ab894a4-2877-4d6b-ad88-2153e07c43e6/run/github_pr_to_piper/origin.resolve_source_ref
0311 09:41:57.487 VERBOSE: PROFILE:   4012 //copybara/8b8f06cc-5064-4a46-95ef-4aa73771837e_4ab894a4-2877-4d6b-ad88-2153e07c43e6/run/github_pr_to_piper
0311 09:41:57.487 WARNING: Cannot migrate http://github.com/grpc/grpc/pull/41843 because the following ci labels have not been passed: [Bazel RBE ASAN C/C++, Clang Tidy (internal CI), Bazel RBE Build Tests, Sanity Checks (internal CI), Bazel RBE Debug C/C++, Bazel RBE Opt C/C++, Windows clang-cl with strict warnings [Build Only], Bazel Basic Tests for Python (Local), Bazel RBE TSAN C/C++]
0311 09:41:57.493 VERBOSE: PROFILE:  10734 //copybara/8b8f06cc-5064-4a46-95ef-4aa73771837e_4ab894a4-2877-4d6b-ad88-2153e07c43e6

markdroth · 2026-03-11T17:02:49Z

I think this PR should go through the normal copybara workflow.

yuanweiz · 2026-03-11T17:15:53Z

I think this PR should go through the normal copybara workflow.

Yeah at first I thought the changed file is github-only, but after checking I realized it's just the folder location that's slightly different.

The copybara error message looks a bit odd though (it seems to suggest various CIs are failing but only 1 of them is). I'm re-triggering Bazel RBE Build Tests only to see if that makes copybara happy.

zifeitong · 2026-03-14T06:10:43Z

There is one more missing cc_library import: https://github.com/grpc/grpc/blob/master/third_party/xxhash/BUILD

Bazel 9 requires explicit load statements for cc_library instead of relying on the implicit native rule. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

smolkaj · 2026-03-14T06:57:35Z

There is one more missing cc_library import: https://github.com/grpc/grpc/blob/master/third_party/xxhash/BUILD

Thanks, fixed

pawbhard · 2026-06-10T17:24:35Z

@yuanweiz Either with this PR or follow up make sure we add bazel compatibility check test in portability test (building with oldest and latest supported version)

yuanweiz · 2026-06-10T17:32:33Z

@yuanweiz Either with this PR or follow up make sure we add bazel compatibility check test in portability test (building with oldest and latest supported version)

Agreed. I approved this because it's harmless so we shouldn't leave it hanging for too long. But realistically I don't think it will fix all the issues with bazel 9.

To @smolkaj, could you finish some pending items:

Change the title to reflect which components (bazel targets) is now buildable with bazel 9
explain how you tested it, what's the bazel version used, etc (could be manual testing)

## Why Bazel 9 is out and gRPC's BCR entry currently doesn't build under it (tracked in grpc#41697). This PR fixes the last remaining blocker. `bazel/cython_library.bzl` was already fixed in this repo. The only remaining issue is `third_party/address_sorting/address_sorting.bzl`, which calls `native.cc_library` without a `load()` — a hard error in Bazel 9, which removed the autoload of native C++ rules. ## Changes - `third_party/address_sorting/address_sorting.bzl`: load `cc_library` explicitly (consistent with e.g. `bazel/cc_grpc_library.bzl`) instead of using `native.cc_library` ## For maintainers Please add the `release notes: no` label (Mergeable requirement) and approve the `check_bzl_deps` workflow run. --------- Signed-off-by: Steffen Smolka <steffen.smolka@gmail.com> Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

This was referenced Mar 1, 2026

Add p4runtime 1.5.0.bcr.2 bazelbuild/bazel-central-registry#7747

Closed

Fix BCR build issues and add Bazel 9 support p4lang/p4runtime#590

Merged

grpc-bot assigned murgatroid99 Mar 1, 2026

smolkaj mentioned this pull request Mar 1, 2026

Add grpc 1.76.0.bcr.2 bazelbuild/bazel-central-registry#7749

Closed

smolkaj force-pushed the bazel9-support branch from b378098 to b9644ec Compare March 1, 2026 04:22

smolkaj marked this pull request as ready for review March 1, 2026 04:22

markdroth assigned yuanweiz and unassigned murgatroid99 Mar 3, 2026

yuanweiz reviewed Mar 9, 2026

View reviewed changes

Comment thread .bazelversion Outdated

Revert .bazelversion bump

ebe04bc

yuanweiz approved these changes Mar 10, 2026

View reviewed changes

yuanweiz added the release notes: no Indicates if PR should not be in release notes label Mar 10, 2026

yuanweiz added the kokoro:run label Mar 10, 2026

grpc-kokoro removed the kokoro:run label Mar 10, 2026

grpc-checks Bot added the bloat/none label Mar 10, 2026

yuanweiz requested a review from markdroth March 11, 2026 16:41

Add missing cc_library import to third_party/xxhash/BUILD

56a2dbe

Bazel 9 requires explicit load statements for cc_library instead of relying on the implicit native rule. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

yuanweiz added the kokoro:force-run label Jun 9, 2026

grpc-kokoro removed the kokoro:force-run label Jun 9, 2026

grpc-checks Bot added per-call-memory/neutral per-channel-memory/neutral bloat/improvement and removed bloat/none labels Jun 9, 2026

yuanweiz approved these changes Jun 9, 2026

View reviewed changes

yuanweiz changed the title ~~Add Bazel 9 support~~ Add Bazel 9 support for //third_party Jun 16, 2026

markdroth merged commit 0f2fc63 into grpc:master Jun 16, 2026
63 checks passed

Conversation

smolkaj commented Mar 1, 2026 • edited by yuanweiz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Why

Changes

For maintainers

Uh oh!

linux-foundation-easycla Bot commented Mar 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smolkaj commented Mar 9, 2026

Uh oh!

smolkaj commented Mar 9, 2026

Uh oh!

yuanweiz commented Mar 9, 2026

Uh oh!

yuanweiz commented Mar 9, 2026

Uh oh!

Uh oh!

smolkaj commented Mar 10, 2026

Uh oh!

smolkaj commented Mar 10, 2026

Uh oh!

yuanweiz left a comment

Choose a reason for hiding this comment

Uh oh!

smolkaj commented Mar 10, 2026

Uh oh!

yuanweiz commented Mar 10, 2026

Uh oh!

yuanweiz commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yuanweiz commented Mar 11, 2026

Uh oh!

markdroth commented Mar 11, 2026

Uh oh!

yuanweiz commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

zifeitong commented Mar 14, 2026

Uh oh!

smolkaj commented Mar 14, 2026

Uh oh!

pawbhard commented Jun 10, 2026

Uh oh!

yuanweiz commented Jun 10, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

smolkaj commented Mar 1, 2026 •

edited by yuanweiz

Loading

linux-foundation-easycla Bot commented Mar 1, 2026 •

edited

Loading

yuanweiz commented Mar 11, 2026 •

edited

Loading

yuanweiz commented Mar 11, 2026 •

edited

Loading