Skip to content

Add grpc 1.76.0.bcr.2#7749

Closed
smolkaj wants to merge 2 commits into
bazelbuild:mainfrom
smolkaj:add-grpc-1.76.0.bcr.2
Closed

Add grpc 1.76.0.bcr.2#7749
smolkaj wants to merge 2 commits into
bazelbuild:mainfrom
smolkaj:add-grpc-1.76.0.bcr.2

Conversation

@smolkaj

@smolkaj smolkaj commented Mar 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

`grpc 1.76.0.bcr.1`'s `bazel_9_fixes.patch` missed `bazel/cython_library.bzl`,
which still calls `native.cc_binary`. Bazel 9 no longer autoloads this rule by
default, so any downstream build that reaches Python gRPC targets fails.

The fix is already on grpc master (grpc/grpc#41757).
This PR extends the existing `bazel_9_fixes.patch` with the same change.

Additionally bumps transitive deps that use bare native rules removed in Bazel 9:

  • `envoy_api` → `0.0.0-20251216` (pulls in `rules_go@0.59.0`, which loads `CcInfo` from `rules_cc`)
  • `re2` → `2025-11-05.bcr.1` (loads `cc_library` from `rules_cc`)

Excludes two targets from Bazel 9 presubmit whose deps lack Bazel 9 support in BCR:

  • `grpc++_test` (depends on `googletest`)
  • `grpc_opencensus_plugin` (depends on `opencensus-cpp`)

@bazel-io

bazel-io commented Mar 1, 2026

Copy link
Copy Markdown
Member

Hello @pawbhard, @rishesh007, @markdroth, @sergiitk, @yuanweiz, @asheshvidyut, @sreenithi, modules you maintain (grpc) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@smolkaj smolkaj mentioned this pull request Mar 1, 2026
Closed
@smolkaj

smolkaj commented Mar 1, 2026

Copy link
Copy Markdown
Contributor Author

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Mar 1, 2026
@smolkaj smolkaj force-pushed the add-grpc-1.76.0.bcr.2 branch 2 times, most recently from fdfcf48 to b7f5d33 Compare March 1, 2026 04:05
@smolkaj smolkaj marked this pull request as ready for review March 1, 2026 04:12
@smolkaj smolkaj mentioned this pull request Mar 1, 2026
Merged
@smolkaj smolkaj force-pushed the add-grpc-1.76.0.bcr.2 branch from b7f5d33 to 98a5253 Compare March 1, 2026 06:20
@smolkaj

smolkaj commented Mar 1, 2026

Copy link
Copy Markdown
Contributor Author

CI seems to be stuck, will close and re-open to get it unstuck.

@smolkaj smolkaj closed this Mar 1, 2026
@smolkaj smolkaj reopened this Mar 1, 2026
@smolkaj

smolkaj commented Mar 9, 2026

Copy link
Copy Markdown
Contributor Author

Gentle reminder, could we get this reviewed/merged?

@smolkaj

smolkaj commented Mar 10, 2026

Copy link
Copy Markdown
Contributor Author

@yuanweiz for visibility

@smolkaj smolkaj mentioned this pull request Mar 10, 2026
Merged
@smolkaj

smolkaj commented Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

I would be very grateful for a review

@smolkaj

smolkaj commented Mar 13, 2026

Copy link
Copy Markdown
Contributor Author

@pawbhard, @rishesh007, @markdroth, @sergiitk, @yuanweiz, @asheshvidyut, @sreenithi

yuanweiz
yuanweiz previously approved these changes Mar 13, 2026
View reviewed changes
bazel-io
bazel-io previously approved these changes Mar 13, 2026
View reviewed changes

@bazel-io bazel-io left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All modules in this PR have been approved by their maintainers. This PR will be merged if all presubmit checks pass.

@bazel-io bazel-io added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Mar 13, 2026
@yuanweiz

yuanweiz commented Mar 13, 2026

Copy link
Copy Markdown
Contributor

This broke a bunch of bazel 9 tests due to missing bazel_features@1.42.1

bazel --host_jvm_args=-Djava.net.preferIPv6Addresses=true --nosystem_rc --nohome_rc info
--
WARNING: The following rc files are no longer being read, please transfer their contents or import their path into one of the standard rc files:
/etc/bazel.bazelrc
ERROR: com.google.devtools.build.lib.bazel.bzlmod.ExternalDepsException: in module dependency chain <root> -> bazel_tools@_ -> bazel_features@1.42.1: module bazel_features@1.42.1 not found in registries:
* file:///Users/buildkite/builds/bk-macos-arm64-bkj3/bazel/bcr-presubmit/modules/bazel_features/1.42.1/MODULE.bazel: not found

@smolkaj
Add grpc 1.76.0.bcr.2
ad0549c 
grpc 1.76.0.bcr.1 missed bazel/cython_library.bzl in its bazel_9_fixes.patch.
That file uses native.cc_binary, which Bazel 9 no longer autoloads by default.
Extend the patch with the fix from upstream master (already merged there).
@smolkaj smolkaj force-pushed the add-grpc-1.76.0.bcr.2 branch from 98a5253 to ad0549c Compare March 14, 2026 02:54
@bazel-io bazel-io dismissed stale reviews from yuanweiz and themself March 14, 2026 02:55

Require module maintainers' approval for newly pushed changes.

@bazel-io bazel-io requested a review from yuanweiz March 14, 2026 02:55
@smolkaj smolkaj force-pushed the add-grpc-1.76.0.bcr.2 branch 3 times, most recently from d514119 to 6685a27 Compare March 14, 2026 03:04
@smolkaj
Fix Bazel 9 compatibility
7c3bb6c 
- Bump envoy_api to 0.0.0-20251216 (rules_go 0.59.0, Bazel 9 compatible)
- Bump re2 to 2025-11-05.bcr.1 (loads cc_library from rules_cc)
- Exclude grpc++_test and grpc_opencensus_plugin from Bazel 9 presubmit
  (googletest and opencensus-cpp lack Bazel 9 support in BCR)
- Fix Windows presubmit to use matrix variable for bazel versions
@smolkaj smolkaj force-pushed the add-grpc-1.76.0.bcr.2 branch from f039c95 to 7c3bb6c Compare March 14, 2026 06:20
@smolkaj

smolkaj commented Mar 14, 2026

Copy link
Copy Markdown
Contributor Author

I got everything to work, but it got pretty complicated.
Wdyt @yuanweiz?

@github-actions

github-actions Bot commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

This PR has been automatically marked as stale because it has not had any activity for 30 days. It will be closed in 14 days if no further activity occurs. Please comment on this PR to keep it open, or ask @bazelbuild/bcr-maintainers to add the not stale label if it's still relevant.

@github-actions github-actions Bot added the stale Issues or PRs that are stale (no activity for 30 days) label Apr 14, 2026
@github-actions

github-actions Bot commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

This PR has been closed due to inactivity.

@github-actions github-actions Bot closed this Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bazel-io bazel-io bazel-io left review comments

@yuanweiz yuanweiz Awaiting requested review from yuanweiz

Assignees

No one assigned

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-url-stability-check Skip the URL stability check for the PR stale Issues or PRs that are stale (no activity for 30 days)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@smolkaj @bazel-io @yuanweiz