[TLS Credentials]: Create InMemoryCertificateProvider to update certificates independently#41484
Closed
anniefrchz wants to merge 21 commits intogrpc:masterfrom
Closed
[TLS Credentials]: Create InMemoryCertificateProvider to update certificates independently#41484anniefrchz wants to merge 21 commits intogrpc:masterfrom
anniefrchz wants to merge 21 commits intogrpc:masterfrom
Conversation
|
|
Contributor
Author
|
Sending this for now, but PR#41490 needs to be merged first |
ffb598f to
0274838
Compare
gtcooke94
approved these changes
Jan 28, 2026
Contributor
gtcooke94
left a comment
There was a problem hiding this comment.
Generally LGTM given the previous iteration was approved :)
Just a few questions
Member
|
Once #41490 is merged, please merge master into this PR, and then I'll review it. Thanks! |
5a2226b to
520664a
Compare
rockspore
reviewed
Jan 30, 2026
Contributor
rockspore
left a comment
There was a problem hiding this comment.
Thanks for the PR. Left a simple question. Please don't consider my review as a blocker. ;)
rockspore
approved these changes
Feb 2, 2026
markdroth
reviewed
Feb 6, 2026
Member
markdroth
left a comment
There was a problem hiding this comment.
This looks really good! Comments are all fairly minor.
Please let me know if you have any questions. Thanks!
src/core/credentials/transport/tls/grpc_tls_certificate_provider.cc
Outdated
Show resolved
Hide resolved
src/core/credentials/transport/tls/grpc_tls_certificate_provider.cc
Outdated
Show resolved
Hide resolved
test/core/credentials/transport/tls/grpc_tls_certificate_provider_test.cc
Outdated
Show resolved
Hide resolved
test/core/credentials/transport/tls/grpc_tls_credentials_options_test.cc
Show resolved
Hide resolved
test/core/credentials/transport/tls/tls_security_connector_test.cc
Outdated
Show resolved
Hide resolved
b87b7f1 to
8cfae6b
Compare
anniefrchz
added a commit
to anniefrchz/grpc
that referenced
this pull request
Feb 11, 2026
…ficates independently (grpc#41484) <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#41484 COPYBARA_INTEGRATE_REVIEW=grpc#41484 from anniefrchz:in_memory_provider d5c64b9 PiperOrigin-RevId: 868750621
Zgoda91
pushed a commit
to Zgoda91/grpc
that referenced
this pull request
Mar 22, 2026
…ficates independently (grpc#41484) <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Closes grpc#41484 COPYBARA_INTEGRATE_REVIEW=grpc#41484 from anniefrchz:in_memory_provider d5c64b9 PiperOrigin-RevId: 868750621
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.