[TlsCredentials]: Reapply allow using a separate cert provider for root and identity certs#41490
Closed
anniefrchz wants to merge 2 commits intogrpc:masterfrom
Closed
[TlsCredentials]: Reapply allow using a separate cert provider for root and identity certs#41490anniefrchz wants to merge 2 commits intogrpc:masterfrom
anniefrchz wants to merge 2 commits intogrpc:masterfrom
Conversation
This reverts commit f06c045.
…ot and identity certs
afb8c72 to
6f71593
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a reapply of PR#41445.
A bug was introduced during the C++ TLSCredentialsOptions configuration where setting a legacy watch_root_cert or watch_identity_cert before actually setting the certificate provider would end up ignoring the legacy certificate provider.
For this PR, make sure that the TLSCredentialsObject does not assign legacy providers until the TlsCredentials object is built. SecureCredentials and SecureServerCredentials use TlsCredentialsOptions::c_credentials_options() to make a deep copy of the c-core tls_credentials_object previous to buil the TlsCredentials.