Fix use-of-uninitialized-value in gRPC#37256
Closed
rschu1ze wants to merge 2 commits intogrpc:masterfrom
Closed
Conversation
This was referenced Jul 19, 2024
Member
|
Thanks for your contribution, @rschu1ze. Please sign the CLA, and we can take a look. |
Contributor
Author
Done - thanks. |
Member
|
You'll need to run clang format on the PR using |
Contributor
Author
|
Sure, done. |
drfloob
approved these changes
Jul 30, 2024
eugeneo
approved these changes
Jul 30, 2024
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
Nov 25, 2024
ClickHouse is an analytical database which has grpc import/export functionality. Testing with msan builds found a uninitialized-value in grpc. Downstream bug report: ClickHouse/ClickHouse#66525 I am not the author of the fix, I am merely contributing the fix back to grpc. - ClickHouse/ClickHouse#66509 - ClickHouse/grpc#41 ClickHouse currently uses grpc 1.59.x ([here](https://github.com/ClickHouse/grpc/commits/ClickHouse/v1.59.2/)), I forward-ported the fix to `master`. Closes grpc#37256 COPYBARA_INTEGRATE_REVIEW=grpc#37256 from rschu1ze:uninit-value e689780 PiperOrigin-RevId: 657620702
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClickHouse is an analytical database which has grpc import/export functionality.
Testing with msan builds found a uninitialized-value in grpc.
Downstream bug report: ClickHouse/ClickHouse#66525
I am not the author of the fix, I am merely contributing the fix back to grpc.
ClickHouse currently uses grpc 1.59.x (here), I forward-ported the fix to
master.