Skip to content

Fix MSan report in GRPC#66509

Merged
alexey-milovidov merged 13 commits intomasterfrom
clickhouse-fix-msan-report-in-epoll
Jul 17, 2024
Merged

Fix MSan report in GRPC#66509
alexey-milovidov merged 13 commits intomasterfrom
clickhouse-fix-msan-report-in-epoll

Conversation

@alexey-milovidov
Copy link
Copy Markdown
Member

@alexey-milovidov alexey-milovidov commented Jul 15, 2024 •
edited by tavplubix
Loading

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Our CI is littered with it. Closes #66525

Information about CI checks: https://clickhouse.com/docs/en/development/continuous-integration/

CI Settings (Only check the boxes if you know what you are doing):

  • Allow: All Required Checks
  • Allow: Stateless tests
  • Allow: Stateful tests
  • Allow: Integration Tests
  • Allow: Performance tests
  • Allow: All Builds
  • Allow: batch 1, 2 for multi-batch jobs
  • Allow: batch 3, 4, 5, 6 for multi-batch jobs
  • Exclude: Style check
  • Exclude: Fast test
  • Exclude: All with ASAN
  • Exclude: All with TSAN, MSAN, UBSAN, Coverage
  • Exclude: All with aarch64, release, debug
  • Do not test
  • Woolen Wolfdog
  • Upload binaries for special builds
  • Disable merge-commit
  • Disable CI cache

@robot-ch-test-poll2 robot-ch-test-poll2 added pr-not-for-changelog This PR should not be mentioned in the changelog submodule changed At least one submodule changed in this PR. labels Jul 15, 2024
@robot-ch-test-poll
Copy link
Copy Markdown
Contributor

robot-ch-test-poll commented Jul 15, 2024 •
edited by robot-ch-test-poll4
Loading

This is an automated comment for commit ec87bfc with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors❌ failure
Successful checks
Check nameDescriptionStatus
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
BuildsThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integration tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@vitlibar vitlibar self-assigned this Jul 15, 2024
@Algunenano Algunenano mentioned this pull request Jul 15, 2024
Closed
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 16, 2024
Merged
19 tasks
@vitlibar vitlibar mentioned this pull request Jul 17, 2024
Merged
@vitlibar
Copy link
Copy Markdown
Member

vitlibar commented Jul 17, 2024

Test failures:

@alexey-milovidov merge?

@antaljanosbenjamin antaljanosbenjamin mentioned this pull request Jul 17, 2024
Merged
19 tasks
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Jul 17, 2024
Merged via the queue into master with commit 9585b79 Jul 17, 2024
@alexey-milovidov alexey-milovidov deleted the clickhouse-fix-msan-report-in-epoll branch July 17, 2024 17:02
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jul 17, 2024
@nikitamikhaylov nikitamikhaylov mentioned this pull request Jul 17, 2024
Merged
19 tasks
@alexey-milovidov alexey-milovidov mentioned this pull request Jul 18, 2024
Merged
18 tasks
@rschu1ze rschu1ze mentioned this pull request Jul 19, 2024
Closed
@rschu1ze
Copy link
Copy Markdown
Member

rschu1ze commented Jul 19, 2024 •
edited
Loading

Contributed back to upstream: grpc/grpc#37256

This was referenced Jul 19, 2024
Merged
Closed
@azat azat mentioned this pull request Jul 22, 2024
Merged
@alexey-milovidov alexey-milovidov added the 🍃 green ci 🌿 Fixing flaky tests in CI label Jul 24, 2024
copybara-service bot pushed a commit to grpc/grpc that referenced this pull request Jul 30, 2024
@rschu1ze @copybara-github
Fix use-of-uninitialized-value in gRPC (#37256)
f553f73 
ClickHouse is an analytical database which has grpc import/export functionality.

Testing with msan builds found a uninitialized-value in grpc.

Downstream bug report: ClickHouse/ClickHouse#66525

I am not the author of the fix, I am merely contributing the fix back to grpc.
- ClickHouse/ClickHouse#66509
- ClickHouse/grpc#41

ClickHouse currently uses grpc 1.59.x ([here](https://github.com/ClickHouse/grpc/commits/ClickHouse/v1.59.2/)), I forward-ported the fix to `master`.

Closes #37256

COPYBARA_INTEGRATE_REVIEW=#37256 from rschu1ze:uninit-value e689780
PiperOrigin-RevId: 657620702
paulosjca pushed a commit to paulosjca/grpc that referenced this pull request Nov 25, 2024
@rschu1ze @paulosjca
Fix use-of-uninitialized-value in gRPC (grpc#37256)
a9e029d 
ClickHouse is an analytical database which has grpc import/export functionality.

Testing with msan builds found a uninitialized-value in grpc.

Downstream bug report: ClickHouse/ClickHouse#66525

I am not the author of the fix, I am merely contributing the fix back to grpc.
- ClickHouse/ClickHouse#66509
- ClickHouse/grpc#41

ClickHouse currently uses grpc 1.59.x ([here](https://github.com/ClickHouse/grpc/commits/ClickHouse/v1.59.2/)), I forward-ported the fix to `master`.

Closes grpc#37256

COPYBARA_INTEGRATE_REVIEW=grpc#37256 from rschu1ze:uninit-value e689780
PiperOrigin-RevId: 657620702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vitlibar vitlibar vitlibar approved these changes

Assignees

@vitlibar vitlibar

Labels

🍃 green ci 🌿 Fixing flaky tests in CI pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo submodule changed At least one submodule changed in this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

use-of-uninitialized-value in gRPC

6 participants

@alexey-milovidov @robot-ch-test-poll @vitlibar @rschu1ze @robot-ch-test-poll2 @robot-ch-test-poll3