Conversation
gtcooke94
added a commit
to gtcooke94/grpc
that referenced
this pull request
Sep 19, 2023
…ry to grpc_ssl_credentials." (grpc#34355) This reverts commit a4ac80c.
gtcooke94
added a commit
that referenced
this pull request
Sep 21, 2023
…c_ssl_credentials, version 2. (#34408) Revert the reversion of the SSL_CTX_new change (#34355 reverted #34180 ) with a fix. There was an issue with using `strcpy` on a `new[] string` in the constructor of `ssl_credentials`. An ASAN test caught this in some CI down the line - `ERROR: AddressSanitizer: alloc-dealloc-mismatch (operator new [] vs free)` That `strcpy` call was changed to `grp_strdup` which duplicates a string in a way that can be freed by `gpr_free` and should resolve the ASAN failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #34180