Skip to content

Revert "[Security] Move ownership of tsi_ssl_client_handshaker_factory to grpc_ssl_credentials."#34355

Merged
ctiller merged 1 commit intomasterfrom
revert-34180-SSL_CTX_new_refactor
Sep 14, 2023
Merged

Revert "[Security] Move ownership of tsi_ssl_client_handshaker_factory to grpc_ssl_credentials."#34355
ctiller merged 1 commit intomasterfrom
revert-34180-SSL_CTX_new_refactor

Conversation

@nanahpang
Copy link
Copy Markdown
Contributor

Reverts #34180

…y to grpc_ssl_credentials. (#34180)"

This reverts commit 36dc5e7.
@nanahpang nanahpang requested a review from erm-g September 14, 2023 21:50
@ctiller ctiller merged commit a4ac80c into master Sep 14, 2023
@ctiller ctiller deleted the revert-34180-SSL_CTX_new_refactor branch September 14, 2023 21:54
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Sep 14, 2023
gtcooke94 added a commit to gtcooke94/grpc that referenced this pull request Sep 19, 2023
gtcooke94 added a commit that referenced this pull request Sep 21, 2023
…c_ssl_credentials, version 2. (#34408)

Revert the reversion of the SSL_CTX_new change (#34355 reverted #34180 )
with a fix.

There was an issue with using `strcpy` on a `new[] string` in the
constructor of `ssl_credentials`. An ASAN test caught this in some CI
down the line - `ERROR: AddressSanitizer: alloc-dealloc-mismatch
(operator new [] vs free)`

That `strcpy` call was changed to `grp_strdup` which duplicates a string
in a way that can be freed by `gpr_free` and should resolve the ASAN
failure.
@ti-chi-bot ti-chi-bot bot mentioned this pull request Jul 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants