[Security] Move ownership of tsi_ssl_client_handshaker_factory to grpc_ssl_credentials.#34180
Merged
gtcooke94 merged 31 commits intogrpc:masterfrom Sep 14, 2023
Merged
Conversation
6b2e1c0 to
295afa6
Compare
tools/run_tests/run_tests.py
Outdated
| sys.path.append(gcp_utils_dir) | ||
|
|
||
| _ROOT = os.path.abspath(os.path.join(os.path.dirname(sys.argv[0]), "../..")) | ||
| _ROOT = os.path.abspath(os.path.join(os.path.dirname(sys.argv[0]), "..", "..")) |
Contributor
There was a problem hiding this comment.
Do we need the changes in this file? Should they be reverted?
Contributor
Author
There was a problem hiding this comment.
These are actually related to the test-pr, this diff should go away when this gets refreshed to the new master
Contributor
Author
There was a problem hiding this comment.
Actually I'm wrong, changing this back
matthewstevenson88
approved these changes
Sep 14, 2023
gtcooke94
added a commit
that referenced
this pull request
Sep 21, 2023
…c_ssl_credentials, version 2. (#34408) Revert the reversion of the SSL_CTX_new change (#34355 reverted #34180 ) with a fix. There was an issue with using `strcpy` on a `new[] string` in the constructor of `ssl_credentials`. An ASAN test caught this in some CI down the line - `ERROR: AddressSanitizer: alloc-dealloc-mismatch (operator new [] vs free)` That `strcpy` call was changed to `grp_strdup` which duplicates a string in a way that can be freed by `gpr_free` and should resolve the ASAN failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the SSL_CTX to the level of the credentials rather than the subchannel.
The SSL_CTX should only get created once per credential rather than once per subchannel.
We should observe no behavior change with this PR, only efficiency gains.