[EventEngine] Make AresResolver build compatible with older c-ares versions#34314
Merged
yijiem merged 5 commits intogrpc:masterfrom Sep 12, 2023
Merged
[EventEngine] Make AresResolver build compatible with older c-ares versions#34314yijiem merged 5 commits intogrpc:masterfrom
AresResolver build compatible with older c-ares versions#34314yijiem merged 5 commits intogrpc:masterfrom
Conversation
AresResolver build compatible older c-ares versions
AresResolver build compatible older c-ares versionsAresResolver build compatible with older c-ares versions
veblush
approved these changes
Sep 12, 2023
apolcyn
approved these changes
Sep 12, 2023
yijiem
added a commit
to yijiem/grpc
that referenced
this pull request
Sep 12, 2023
…versions (grpc#34314) Tested by changing c-ares to `1.14.0` in Bazel dependency and verify that the `posix_event_engine_test` build. The test would fail though since c-ares versions < `1.16.0` does not come with address sorting capability so the relevant test cases will fail. But this is probably sufficient to make the Cloud C++ CI job pass and unblock the 1.58 release. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
yijiem
added a commit
that referenced
this pull request
Sep 12, 2023
…ble with older c-ares versions" to v1.58.x (#34324) Backport #34314 to v1.58.x. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested by changing c-ares to
1.14.0in Bazel dependency and verify that theposix_event_engine_testbuild. The test would fail though since c-ares versions <1.16.0does not come with address sorting capability so the relevant test cases will fail. But this is probably sufficient to make the Cloud C++ CI job pass and unblock the 1.58 release.