Skip to content

[EventEngine] Backport "[EventEngine] Make AresResolver build compatible with older c-ares versions" to v1.58.x#34324

Merged
yijiem merged 5 commits intogrpc:v1.58.xfrom
yijiem:v1.58.x
Sep 12, 2023
Merged

[EventEngine] Backport "[EventEngine] Make AresResolver build compatible with older c-ares versions" to v1.58.x#34324
yijiem merged 5 commits intogrpc:v1.58.xfrom
yijiem:v1.58.x

Conversation

@yijiem
Copy link
Copy Markdown
Member

@yijiem yijiem commented Sep 12, 2023

Backport #34314 to v1.58.x.

…versions (grpc#34314)

Tested by changing c-ares to `1.14.0` in Bazel dependency and verify
that the `posix_event_engine_test` build. The test would fail though
since c-ares versions < `1.16.0` does not come with address sorting
capability so the relevant test cases will fail. But this is probably
sufficient to make the Cloud C++ CI job pass and unblock the 1.58
release.

<!--

If you know who should review your pull request, please assign it to
that
person, otherwise the pull request would get assigned randomly.

If your pull request is for a specific language, please add the
appropriate
lang label.

-->
@yijiem yijiem added the release notes: no Indicates if PR should not be in release notes label Sep 12, 2023
@yijiem yijiem requested a review from veblush September 12, 2023 18:36
@yijiem yijiem marked this pull request as ready for review September 12, 2023 18:37
@yijiem yijiem enabled auto-merge (squash) September 12, 2023 23:09
@yijiem yijiem merged commit ed6634c into grpc:v1.58.x Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants