Skip to content

[LB policy API] add helper methods for getting channel creds#33451

Merged
markdroth merged 8 commits intogrpc:masterfrom
markdroth:lb_channel_creds_api_cleanup2
Jun 15, 2023
Merged

[LB policy API] add helper methods for getting channel creds#33451
markdroth merged 8 commits intogrpc:masterfrom
markdroth:lb_channel_creds_api_cleanup2

Conversation

@markdroth
Copy link
Copy Markdown
Member

@markdroth markdroth commented Jun 14, 2023 •
edited
Loading

This addresses a long-standing TODO that we couldn't do prior to #25586.

For details, see internal doc go/grpc-rls-callcreds-to-server. CC @ejona86

@markdroth markdroth added the release notes: no Indicates if PR should not be in release notes label Jun 14, 2023
@markdroth markdroth marked this pull request as ready for review June 15, 2023 18:20
@markdroth markdroth requested a review from eugeneo June 15, 2023 18:20
@markdroth markdroth merged commit 50e9702 into grpc:master Jun 15, 2023
@markdroth markdroth deleted the lb_channel_creds_api_cleanup2 branch June 15, 2023 19:24
@markdroth markdroth mentioned this pull request Jun 15, 2023
Merged
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Jun 15, 2023
markdroth added a commit that referenced this pull request Jun 16, 2023
@markdroth
[xDS] change CDS policy to get channel creds via the helper (#33457)
e7a339d 
I missed this one in #33451.
@markdroth markdroth mentioned this pull request Aug 24, 2023
Merged
markdroth added a commit that referenced this pull request Aug 25, 2023
@markdroth
[LB policy API] update some TODOs and comments (#34156)
90d1851 
- Add a couple of new TODOs that we need to address before making the LB
policy API public.
- Remove a comment about picker thread-safety that should be been
removed in #31973.
- Remove a TODO that was addressed in #33451.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eugeneo eugeneo eugeneo approved these changes

Assignees

No one assigned

Labels

bloat/low imported Specifies if the PR has been imported to the internal repository lang/c++ lang/core per-call-memory/neutral per-channel-memory/neutral release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markdroth @eugeneo