[LB policy API] update some TODOs and comments#34156
Merged
markdroth merged 1 commit intogrpc:masterfrom Aug 25, 2023
Merged
Conversation
Member
markdroth
commented
Aug 24, 2023
- Add a couple of new TODOs that we need to address before making the LB policy API public.
- Remove a comment about picker thread-safety that should be been removed in client channel: don't hold mutexes while calling the ConfigSelector or the LB picker #31973.
- Remove a TODO that was addressed in [LB policy API] add helper methods for getting channel creds #33451.
eugeneo
approved these changes
Aug 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.