[LB policies] remove unnecessary check for null config#32932
Merged
markdroth merged 1 commit intogrpc:masterfrom Apr 24, 2023
Merged
[LB policies] remove unnecessary check for null config#32932markdroth merged 1 commit intogrpc:masterfrom
markdroth merged 1 commit intogrpc:masterfrom
Conversation
eugeneo
approved these changes
Apr 24, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
These checks have not been needed since way back in grpc#22100, but they were never removed, and they've even propagated to a bunch of new policies via copy-paste.
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
May 4, 2023
These checks have not been needed since way back in grpc#22100, but they were never removed, and they've even propagated to a bunch of new policies via copy-paste.
markdroth
added a commit
that referenced
this pull request
May 11, 2023
Also remove a check in the weighted_target LB policy that I somehow missed in #32932.
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
May 17, 2023
Also remove a check in the weighted_target LB policy that I somehow missed in grpc#32932.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
These checks have not been needed since way back in #22100, but they were never removed, and they've even propagated to a bunch of new policies via copy-paste.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
Also remove a check in the weighted_target LB policy that I somehow missed in #32932.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These checks have not been needed since way back in #22100, but they were never removed, and they've even propagated to a bunch of new policies via copy-paste.