Always construct LB policy config, even when only the policy name is specified.#22100
Merged
markdroth merged 1 commit intogrpc:masterfrom Feb 26, 2020
Merged
Conversation
yashykt
approved these changes
Feb 26, 2020
Member
yashykt
left a comment
There was a problem hiding this comment.
Seems ok and cleaner to me. Was there any other motivation for this?
Member
Author
|
My main motivation was to make the changes in #22101 easier. Thanks for the review! |
0e138aa to
48b9cd9
Compare
markdroth
added a commit
that referenced
this pull request
Apr 24, 2023
These checks have not been needed since way back in #22100, but they were never removed, and they've even propagated to a bunch of new policies via copy-paste.
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
These checks have not been needed since way back in grpc#22100, but they were never removed, and they've even propagated to a bunch of new policies via copy-paste.
paulosjca
pushed a commit
to paulosjca/grpc
that referenced
this pull request
May 4, 2023
These checks have not been needed since way back in grpc#22100, but they were never removed, and they've even propagated to a bunch of new policies via copy-paste.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
These checks have not been needed since way back in #22100, but they were never removed, and they've even propagated to a bunch of new policies via copy-paste.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.