Disable testKeepaliveWithV2API test case for objc interop test#32350
Merged
yijiem merged 8 commits intogrpc:masterfrom Feb 11, 2023
Merged
Disable testKeepaliveWithV2API test case for objc interop test#32350yijiem merged 8 commits intogrpc:masterfrom
yijiem merged 8 commits intogrpc:masterfrom
Conversation
drfloob
approved these changes
Feb 11, 2023
Member
drfloob
left a comment
There was a problem hiding this comment.
LGTM with nits, presuming @sampajano is willing to disable this test. Please wait for his review as well.
sampajano
approved these changes
Feb 11, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…32350) This test has a race and is flaky, see [b/268379869](https://b.corp.google.com/issues/268379869). It sends an RPC to the interop server with 0s `keepaliveTimeout` and expects the keepalive watchdog timer to fire immediately before the server acks the ping. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…rt"" (grpc#32341) Reverts grpc#32339 Rolling this forward after grpc#32350.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
This test has a race and is flaky, see [b/268379869](https://b.corp.google.com/issues/268379869). It sends an RPC to the interop server with 0s `keepaliveTimeout` and expects the keepalive watchdog timer to fire immediately before the server acks the ping. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test has a race and is flaky, see b/268379869. It sends an RPC to the interop server with 0s
keepaliveTimeoutand expects the keepalive watchdog timer to fire immediately before the server acks the ping.