Revert "[EventEngine] RunAfter migration: grpc_chttp2_transport"#32339
Merged
Revert "[EventEngine] RunAfter migration: grpc_chttp2_transport"#32339
Conversation
…)" This reverts commit 1b3eade.
ctiller
approved these changes
Feb 9, 2023
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…c#32339) Reverts grpc#32240 Breaks `grpc/core/master/macos/grpc_objc_bazel_test`, sample run: https://source.cloud.google.com/results/invocations/04e5a95b-5f06-4b3e-95fe-5e1895068475/targets Seems like the `testKeepaliveWithV2API` test case failed: ``` Test Case '-[InteropTestsLocalCleartext testKeepaliveWithV2API]' started. <unknown>:0: error: -[InteropTestsLocalCleartext testKeepaliveWithV2API] : Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "Keepalive". Test Case '-[InteropTestsLocalCleartext testKeepaliveWithV2API]' failed (5.547 seconds). ...... Test Case '-[InteropTestsLocalSSL testKeepaliveWithV2API]' started. <unknown>:0: error: -[InteropTestsLocalSSL testKeepaliveWithV2API] : Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "Keepalive". Test Case '-[InteropTestsLocalSSL testKeepaliveWithV2API]' failed (5.011 seconds). ```
XuanWang-Amos
pushed a commit
to XuanWang-Amos/grpc
that referenced
this pull request
May 1, 2023
…rt"" (grpc#32341) Reverts grpc#32339 Rolling this forward after grpc#32350.
wanlin31
pushed a commit
that referenced
this pull request
May 18, 2023
) Reverts #32240 Breaks `grpc/core/master/macos/grpc_objc_bazel_test`, sample run: https://source.cloud.google.com/results/invocations/04e5a95b-5f06-4b3e-95fe-5e1895068475/targets Seems like the `testKeepaliveWithV2API` test case failed: ``` Test Case '-[InteropTestsLocalCleartext testKeepaliveWithV2API]' started. <unknown>:0: error: -[InteropTestsLocalCleartext testKeepaliveWithV2API] : Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "Keepalive". Test Case '-[InteropTestsLocalCleartext testKeepaliveWithV2API]' failed (5.547 seconds). ...... Test Case '-[InteropTestsLocalSSL testKeepaliveWithV2API]' started. <unknown>:0: error: -[InteropTestsLocalSSL testKeepaliveWithV2API] : Asynchronous wait failed: Exceeded timeout of 5 seconds, with unfulfilled expectations: "Keepalive". Test Case '-[InteropTestsLocalSSL testKeepaliveWithV2API]' failed (5.011 seconds). ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #32240
Breaks
grpc/core/master/macos/grpc_objc_bazel_test, sample run: https://source.cloud.google.com/results/invocations/04e5a95b-5f06-4b3e-95fe-5e1895068475/targetsSeems like the
testKeepaliveWithV2APItest case failed: