Fix the setuptools distutils overriding issue#28393
Merged
lidizheng merged 9 commits intogrpc:masterfrom Dec 21, 2021
Merged
Conversation
Vignesh2208
approved these changes
Dec 21, 2021
gnossen
approved these changes
Dec 21, 2021
Contributor
gnossen
left a comment
There was a problem hiding this comment.
Thanks for tracking this down. Looks like a tricky issue.
Contributor
Author
|
Yeah... and I still not sure why setuptools's monkey patch failed in our environment. |
lidizheng
added a commit
to lidizheng/grpc
that referenced
this pull request
Jan 20, 2022
* Fix the distutil install issue * Try to move setuptools install forward * Try pin the distribution tools * Enforce local distutil * Fix script order of definition * Add comment * Try to fix the setuptool monkey patch * Clean-up imports for commands.py * Pin 59.6.0 instead of 59.7.0 (incomplete release)
veblush
pushed a commit
that referenced
this pull request
Jan 20, 2022
* Fix the distutil install issue * Try to move setuptools install forward * Try pin the distribution tools * Enforce local distutil * Fix script order of definition * Add comment * Try to fix the setuptool monkey patch * Clean-up imports for commands.py * Pin 59.6.0 instead of 59.7.0 (incomplete release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28391 b/211485805
The latest
setuptools(>= 60.0.0) tries to replacedistutils:The main reason is
we don't have many folks contributing to distutils any more, so they re-implemented it insidesetuptools.Unfortunately, the default overriding behavior breaks under several environments, including our Kokoro job. They have released 5 times in that 24 hours, but the issue still persists. Technically, we should work to embrace the new
distutils, but let's upgrade after the CIs are green againWe sort of prepared for this failure but it still got us. Our repo tried to pin
pipandsetuptoolsbefore building wheels, in this case,setuptoolsis bundled withpip, causing the CI job to fail at thepipinstallation step.For "Distribution Tests Python Linux" failure:
This PR didn't fix the __wrap_memcpy issue, I posted another fix at #28397. Related b/211487922 #24028.
The gcc-regression-on-memcpy: https://www.win.tue.nl/~aeb/linux/misc/gcc-semibug.html