Remove __wrap_memcpy compatibility hack#28397
Closed
lidizheng wants to merge 2 commits intogrpc:masterfrom
Closed
Conversation
98f00cb to
caf3aaa
Compare
Vignesh2208
approved these changes
Dec 22, 2021
Contributor
|
Please don't do this. This will break binary packages built on glibc running on musl libc. Ruby is a prime suspect for this sort of breakage. |
This was referenced Dec 22, 2021
Contributor
Author
|
Fixed by #28409. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parent PR: #28393
Fixes b/211487922 #24028.
The gcc-regression-on-memcpy: https://www.win.tue.nl/~aeb/linux/misc/gcc-semibug.html
As title, this PR removes the compatibility hack for glibc < 2.14. This PR is the updated-with-master-branch version of #23385, which solves the same problem and was blocked by some artifact-building 10 months ago.
This PR might cause breakage for glibc < 2.14 (more than 10 years old). CC @nicolasnoble
prod:grpc/core/experimental/grpc_build_artifacts_multiplatform