use fixed c++ server image for python tests#27096
Merged
ericgribkoff merged 2 commits intogrpc:masterfrom Aug 24, 2021
Merged
Conversation
lidizheng
approved these changes
Aug 24, 2021
| readonly SECONDARY_GKE_CLUSTER_NAME="interop-test-psm-sec-v2-us-west1-b" | ||
| readonly SECONDARY_GKE_CLUSTER_ZONE="us-west1-b" | ||
| ## xDS test client Docker images | ||
| readonly SERVER_IMAGE_NAME="gcr.io/grpc-testing/xds-interop/python-server" |
Contributor
There was a problem hiding this comment.
I would recommend to keep the variable name for better readability.
Contributor
Author
|
Adhoc run (failover test passed): https://fusion2.corp.google.com/invocations/350c6a54-47f2-4631-856a-2a6f714a75f1 |
lidizheng
pushed a commit
to lidizheng/grpc
that referenced
this pull request
Sep 23, 2021
* use fixed c++ server image for python tests * use variable name
sergiitk
added a commit
to sergiitk/grpc
that referenced
this pull request
Aug 19, 2022
Undoes grpc#27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see grpc#30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see grpc#30636. All other LB tests should work with the python server just fine.
sergiitk
added a commit
that referenced
this pull request
Aug 19, 2022
Undoes #27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see #30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see #30636. All other LB tests should work with the python server just fine.
sergiitk
added a commit
to sergiitk/grpc
that referenced
this pull request
Aug 19, 2022
) Undoes grpc#27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see grpc#30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see grpc#30636. All other LB tests should work with the python server just fine.
sergiitk
added a commit
to sergiitk/grpc
that referenced
this pull request
Aug 19, 2022
) Undoes grpc#27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see grpc#30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see grpc#30636. All other LB tests should work with the python server just fine.
sergiitk
added a commit
to sergiitk/grpc
that referenced
this pull request
Aug 19, 2022
) Undoes grpc#27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see grpc#30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see grpc#30636. All other LB tests should work with the python server just fine.
sergiitk
added a commit
to sergiitk/grpc
that referenced
this pull request
Aug 19, 2022
) Undoes grpc#27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see grpc#30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see grpc#30636. All other LB tests should work with the python server just fine.
sergiitk
added a commit
to sergiitk/grpc
that referenced
this pull request
Aug 19, 2022
) Undoes grpc#27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see grpc#30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see grpc#30636. All other LB tests should work with the python server just fine.
sergiitk
added a commit
to sergiitk/grpc
that referenced
this pull request
Aug 19, 2022
) Undoes grpc#27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see grpc#30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see grpc#30636. All other LB tests should work with the python server just fine.
sergiitk
added a commit
to sergiitk/grpc
that referenced
this pull request
Aug 19, 2022
) Undoes grpc#27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see grpc#30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see grpc#30636. All other LB tests should work with the python server just fine.
sergiitk
added a commit
to sergiitk/grpc
that referenced
this pull request
Aug 19, 2022
) Undoes grpc#27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see grpc#30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see grpc#30636. All other LB tests should work with the python server just fine.
sergiitk
added a commit
to sergiitk/grpc
that referenced
this pull request
Aug 19, 2022
) Undoes grpc#27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see grpc#30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see grpc#30636. All other LB tests should work with the python server just fine.
This was referenced Aug 19, 2022
ejona86
pushed a commit
that referenced
this pull request
Aug 19, 2022
…#30656) Undoes #27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see #30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see #30636. All other LB tests should work with the python server just fine.
ejona86
pushed a commit
that referenced
this pull request
Aug 19, 2022
…#30657) Undoes #27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see #30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see #30636. All other LB tests should work with the python server just fine.
ejona86
pushed a commit
that referenced
this pull request
Aug 19, 2022
…#30658) Undoes #27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see #30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see #30636. All other LB tests should work with the python server just fine.
ejona86
pushed a commit
that referenced
this pull request
Aug 19, 2022
…#30659) Undoes #27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see #30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see #30636. All other LB tests should work with the python server just fine.
ejona86
pushed a commit
that referenced
this pull request
Aug 19, 2022
…#30660) Undoes #27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see #30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see #30636. All other LB tests should work with the python server just fine.
ejona86
pushed a commit
that referenced
this pull request
Aug 19, 2022
…#30661) Undoes #27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see #30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see #30636. All other LB tests should work with the python server just fine.
ejona86
pushed a commit
that referenced
this pull request
Aug 19, 2022
…#30662) Undoes #27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see #30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see #30636. All other LB tests should work with the python server just fine.
ejona86
pushed a commit
that referenced
this pull request
Aug 19, 2022
…#30663) Undoes #27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see #30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see #30636. All other LB tests should work with the python server just fine.
sergiitk
added a commit
that referenced
this pull request
Aug 19, 2022
…#30655) Undoes #27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see #30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see #30636. All other LB tests should work with the python server just fine.
sergiitk
added a commit
to sergiitk/grpc
that referenced
this pull request
Aug 7, 2023
) Undoes grpc#27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see grpc#30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see grpc#30636. All other LB tests should work with the python server just fine.
ejona86
pushed a commit
that referenced
this pull request
Aug 7, 2023
… backport) (#34002) Backport of #30637 to v1.49.x. --- Undoes #27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see #30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see #30636. All other LB tests should work with the python server just fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.