xDS interop: Python LB tests build and use the python server (v1.49.x backport)#34002
Merged
ejona86 merged 1 commit intogrpc:v1.49.xfrom Aug 7, 2023
Conversation
) Undoes grpc#27096. While we lost context why py tests were used pinned cpp server, we think this is due to lack of support of the set_not_serving RPC in the python server, see grpc#30635. This RPC is only used in two tests, and for them we added a temporary override of the test server to the reference Java server, see grpc#30636. All other LB tests should work with the python server just fine.
eugeneo
approved these changes
Aug 7, 2023
Member
Author
|
For posterity - this backport was missing. We discovered it because of an image vulnerability report referring to this specific tag: |
Member
Author
|
Correctness check: after applying this backport, the difference between v1.49.x and v1.50.x is diff --git a/tools/internal_ci/linux/grpc_xds_k8s_lb_python.sh b/tools/internal_ci/linux/grpc_xds_k8s_lb_python.sh
index 431449925f..81d9fd2358 100755
--- a/tools/internal_ci/linux/grpc_xds_k8s_lb_python.sh
+++ b/tools/internal_ci/linux/grpc_xds_k8s_lb_python.sh
@@ -174,7 +174,7 @@ main() {
# Run tests
cd "${TEST_DRIVER_FULL_DIR}"
local failed_tests=0
- test_suites=("api_listener_test" "change_backend_service_test" "failover_test" "remove_neg_test" "round_robin_test" "outlier_detection_test")
+ test_suites=("api_listener_test" "change_backend_service_test" "failover_test" "remove_neg_test" "round_robin_test")
for test in "${test_suites[@]}"; do
run_test $test || (( ++failed_tests ))
doneThis means the patch was applied correctly, and there are no other unexpected changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #30637 to v1.49.x.
Undoes #27096.
While we lost context why py tests were used pinned cpp server,
we think this is due to lack of support of the set_not_serving RPC
in the python server, see #30635.
This RPC is only used in two tests, and for them we added a
temporary override of the test server to the reference Java server,
see #30636.
All other LB tests should work with the python server just fine.