Ensure C89 compatibility in Linux tests#2034
Merged
nathanielmanistaatgoogle merged 1 commit intogrpc:masterfrom Jun 11, 2015
Merged
Ensure C89 compatibility in Linux tests#2034nathanielmanistaatgoogle merged 1 commit intogrpc:masterfrom
nathanielmanistaatgoogle merged 1 commit intogrpc:masterfrom
Conversation
Contributor
|
LGTM; waiting on Travis. |
Contributor
|
Green! |
Contributor
|
Apologies for going back on my LGTM, but could you tweak the commit message? There doesn't appear to be anything test-related in the content of this change. |
Contributor
Author
There was a problem hiding this comment.
@nathanielmanistaatgoogle I believe this is test related. More importantly, it isn't related to... well, just about anything else. No one but test-runners in environments including GCC/Clang and BASH-compatible shells are going to see the effects of that flag.
Contributor
There was a problem hiding this comment.
Right you are; thanks.
Contributor
Author
|
Although, I'm editing the commit message anyway because I totally misspelled compatibility. |
nathanielmanistaatgoogle
added a commit
that referenced
this pull request
Jun 11, 2015
Ensure C89 compatibility in Linux tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stops us from blindly hitting scenarios like #1895.