Skip to content

Some compilers don't like C99.#1895

Merged
soltanmm merged 1 commit intogrpc:masterfrom
nicolasnoble:python-is-not-c89
Jun 4, 2015
Merged

Some compilers don't like C99.#1895
soltanmm merged 1 commit intogrpc:masterfrom
nicolasnoble:python-is-not-c89

Conversation

@nicolasnoble
Copy link
Copy Markdown
Contributor

No description provided.

@soltanmm
Copy link
Copy Markdown
Contributor

soltanmm commented Jun 3, 2015

Waiting on Travis...

@ctiller
Copy link
Copy Markdown
Member

ctiller commented Jun 3, 2015

Can we change compiler flags to prevent this in future?

On Wed, Jun 3, 2015, 1:45 PM Masood Malekghassemi notifications@github.com
wrote:

Waiting on Travis...


Reply to this email directly or view it on GitHub
#1895 (comment).

@soltanmm
Copy link
Copy Markdown
Contributor

soltanmm commented Jun 3, 2015

Yes, though it looks like those flags are going to be GCC/Clang specific... which is fine as far as our test scripts and Linux/Mac packaging go, I think?

soltanmm added a commit that referenced this pull request Jun 4, 2015
@soltanmm soltanmm merged commit aa152ef into grpc:master Jun 4, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jan 31, 2019
@lock lock bot unassigned soltanmm Jan 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants