Allow barrier kissing_gate with bicycle=yes for all bicycle profiles,…#2340
Merged
karussell merged 5 commits intographhopper:masterfrom Jun 24, 2021
Merged
Allow barrier kissing_gate with bicycle=yes for all bicycle profiles,…#2340karussell merged 5 commits intographhopper:masterfrom
karussell merged 5 commits intographhopper:masterfrom
Conversation
… see discussion in graphhopper#407.
Member
|
Thanks! |
karussell
reviewed
Jun 14, 2021
…ks for all bicycles except for mountainbike or when tagged together with bicycle=yes.
ratrun
added a commit
to ratrun/biketourplanner
that referenced
this pull request
Jun 17, 2021
…ntialBarriers with passByDefaultBarriers as result of graphhopper#2340. Removal of configure option "blockByDefault".
karussell
added a commit
that referenced
this pull request
Jun 24, 2021
* Replace absoluteBarriers with blockByDefaultBarriers and replace potentialBarriers with passByDefaultBarriers as result of #2340. Removal of configure option "blockByDefault". * avoid changing tests too much Co-authored-by: ratrun <ratrun@gmx.at>
Member
|
Would you mind updating this PR due to the merged changes in #2345? |
…ate blocks for all bicycles except for mountainbike or when tagged together with bicycle=yes." This reverts commit bba2e67. Revert "Allow barrier kissing_gate with bicycle=yes for all bicycle profiles, see discussion in graphhopper#407." This reverts commit e5db3b5.
… as result of discussion in graphhopper#407.
Contributor
Author
Member
|
LGTM - thanks! |
Contributor
Author
|
Could you please finally close #407? |
Member
|
I would wait until it is deployed - should happen in the next 2 days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… see discussion in #407.
I additionally moved the turn_stile from the list of absolute barriers to the potentials.