Conversation
…ntialBarriers with passByDefaultBarriers as result of #2340. Removal of configure option "blockByDefault".
| final String customCar = "custom_car"; | ||
| final String emptyCar = "empty_car"; | ||
| CustomModel customModel = new CustomModel(); | ||
| customModel.addToSpeed(Statement.If("road_class == TERTIARY", Statement.Op.MULTIPLY, 0.1)); |
There was a problem hiding this comment.
the problem is now that previously barriers hindered using the track and when we avoid tertiary roads by so much it is forced into using tracks. In general we should think about having a bit slower speed on tracks for car, but this is for another issue.
| <tag k="name" v="Wiesbaden-Naurod"/> | ||
| </node> | ||
| <node id="20" lat="52" lon="9.4" version="1"> | ||
| <tag k="barrier" v="gate"/> |
There was a problem hiding this comment.
gate is passable by default now, so we either need a blockByDefaultBarrier or an additional access tag
| passByDefaultBarriers.add("kissing_gate"); | ||
| passByDefaultBarriers.add("swing_gate"); | ||
| passByDefaultBarriers.add("cattle_grid"); | ||
| passByDefaultBarriers.add("chain"); |
There was a problem hiding this comment.
Not sure if kissing_gate and chain should be really pass by default.
There was a problem hiding this comment.
Here I was wondering as well, but I didn't want to mix changes.
There was a problem hiding this comment.
Ok, let's do this in a separate PR. Do you think the other changes look fine?
There was a problem hiding this comment.
There is a similar case for the stile and turn_stile barrier, which should be moved in a seperate PR. Besides that it looks fine to me now.
| // respect one way! | ||
| // http://localhost:8989/?point=55.819066%2C37.596374&point=55.818898%2C37.59661 | ||
| queries.add(new Query(55.819066, 37.596374, 55.818898, 37.59661, 1114, 23)); | ||
| queries.add(new Query(55.818702, 37.595564, 55.818536, 37.595848, 1114, 23)); |
There was a problem hiding this comment.
I needed to move the coordinates (so that they snap differently) as some nearby roads are now accessible due to open barriers
|
Isn't this a breaking change, as it removes the option to block by default and only allow access if explicitly allowed. Might be worthwhile to add this to the changelog? |
This feature is not removed and can be controlled via a list of tags (that subclasses can use). |
|
Thanks for the clarification, yes you are right. So now a fence with motorcar=yes would be also accepted in the routing. I thought these tags would be still these "absolute barriers" that just block access. |
Yes, exactly. So IMO an improvement probably also for other cases. |
Replaces #2344
blockByDefaultBarriers)passByDefaultBarriers)