cli: expand what files we watch in grafbase dev#1774
Merged
Conversation
The previous logic looks like this: - The file is schema.graphql, grafbase.config.ts or .env at the root, or inside a grafbase/ subdirectory OR - The file is under grafbase/, resolvers/ or auth/ - AND it isn't inside node_modules/, or generate/, or a lockfile - AND has one of the following extensions: "js", "ts", "jsx", "tsx", "mjs", "mts", "wasm", "cjs", "json", "yaml", "yml", This commit expands the second branch of the conditional to any directory in the project (we still watch the same project root). There are new ignores for dist/ and target/ folders, since these tend to contain build artifacts rather than source files. closes GB-6881
Merged
yoav-lavi
reviewed
Jun 13, 2024
tomhoule
added a commit
that referenced
this pull request
Jun 13, 2024
Features - You can now filter on text columns with the LIKE operator on the postgres connector (https://www.postgresql.org/docs/current/functions-matching.html). #1764 - The postgres connector now uses a connection pool instead of a single connection in `grafbase start`. #1771 - The postgres connector now supports multiple relations between two tables. See the pull request (#1770) for an example. - Fixed a bug with enum values sent to subgraphs in `grafbase dev` for federated graphs. #1766 - Expand the scope of files watched for changes in `grafbase dev`. #1774
tomhoule
added a commit
that referenced
this pull request
Jun 13, 2024
Features - You can now filter on text columns with the LIKE operator on the postgres connector (https://www.postgresql.org/docs/current/functions-matching.html). #1764 - The postgres connector now uses a connection pool instead of a single connection in `grafbase start`. #1771 - The postgres connector now supports multiple relations between two tables. See the pull request (#1770) for an example. - Fixed a bug with enum values sent to subgraphs in `grafbase dev` for federated graphs. #1766 - Expand the scope of files watched for changes in `grafbase dev`. #1774
tomhoule
added a commit
that referenced
this pull request
Jun 13, 2024
Features - You can now filter on text columns with the LIKE operator on the postgres connector (https://www.postgresql.org/docs/current/functions-matching.html). #1764 - The postgres connector now uses a connection pool instead of a single connection in `grafbase start`. #1771 - The postgres connector now supports multiple relations between two tables. See the pull request (#1770) for an example. - Fixed a bug with enum values sent to subgraphs in `grafbase dev` for federated graphs. #1766 - Expand the scope of files watched for changes in `grafbase dev`. #1774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous logic looks like this:
OR
This commit expands the second branch of the conditional to any directory in the project (we still watch the same project root). There are new ignores for dist/ and target/ folders, since these tend to contain build artifacts rather than source files.
closes GB-6881