Merged
Conversation
8ec99ac to
ca30e91
Compare
tomhoule
approved these changes
Jun 12, 2024
| match self.graph[value_ids].binary_search_by(|enum_value| self.ctx.strings[enum_value.name].as_str().cmp(name)) | ||
| { | ||
| Ok(id) => Ok(SchemaInputValue::EnumValue(EnumValueId::from(id))), | ||
| Ok(id) => Ok(SchemaInputValue::EnumValue(r#enum.value_ids.get(id).unwrap())), |
Contributor
There was a problem hiding this comment.
So we were getting the value with id(x), say, 3, instead of the third value inside the range, right?
Contributor
Author
There was a problem hiding this comment.
so easy to miss with simple tests
tomhoule
added a commit
that referenced
this pull request
Jun 13, 2024
Features - You can now filter on text columns with the LIKE operator on the postgres connector (https://www.postgresql.org/docs/current/functions-matching.html). #1764 - The postgres connector now uses a connection pool instead of a single connection in `grafbase start`. #1771 - The postgres connector now supports multiple relations between two tables. See the pull request (#1770) for an example. - Fixed a bug with enum values sent to subgraphs in `grafbase dev` for federated graphs. #1766
Merged
tomhoule
added a commit
that referenced
this pull request
Jun 13, 2024
Features - You can now filter on text columns with the LIKE operator on the postgres connector (https://www.postgresql.org/docs/current/functions-matching.html). #1764 - The postgres connector now uses a connection pool instead of a single connection in `grafbase start`. #1771 - The postgres connector now supports multiple relations between two tables. See the pull request (#1770) for an example. - Fixed a bug with enum values sent to subgraphs in `grafbase dev` for federated graphs. #1766 - Expand the scope of files watched for changes in `grafbase dev`. #1774
tomhoule
added a commit
that referenced
this pull request
Jun 13, 2024
Features - You can now filter on text columns with the LIKE operator on the postgres connector (https://www.postgresql.org/docs/current/functions-matching.html). #1764 - The postgres connector now uses a connection pool instead of a single connection in `grafbase start`. #1771 - The postgres connector now supports multiple relations between two tables. See the pull request (#1770) for an example. - Fixed a bug with enum values sent to subgraphs in `grafbase dev` for federated graphs. #1766 - Expand the scope of files watched for changes in `grafbase dev`. #1774
tomhoule
added a commit
that referenced
this pull request
Jun 13, 2024
Features - You can now filter on text columns with the LIKE operator on the postgres connector (https://www.postgresql.org/docs/current/functions-matching.html). #1764 - The postgres connector now uses a connection pool instead of a single connection in `grafbase start`. #1771 - The postgres connector now supports multiple relations between two tables. See the pull request (#1770) for an example. - Fixed a bug with enum values sent to subgraphs in `grafbase dev` for federated graphs. #1766 - Expand the scope of files watched for changes in `grafbase dev`. #1774
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Incorrectly used indices, which ended up mixing enums.