fix(loki.process): Registration of stage.metric when used inside stage.match#5460
Merged
fix(loki.process): Registration of stage.metric when used inside stage.match#5460
Conversation
2f8907b to
b34a5cc
Compare
Draft
grafana-alloybot bot
pushed a commit
that referenced
this pull request
Feb 10, 2026
…e.match (#5460) ### Pull Request Details When reloading config for `loki.process` we have had issues where metrics would be registered multiple times. It was fixed in #1292. But if you have metrics in `stage.match` you will hit the same issue because we never cleaned them up: ``` stage.match { selector = `{ test="" }` stage.metrics { metric.counter { name = "counter" description = "some metric desc" action = "inc" match_all = true max_idle_duration = "12h" } } } ``` ### Issue(s) fixed by this Pull Request ### Notes to the Reviewer Test added in pr fails on main ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [x] Tests updated - [ ] Config converters updated (cherry picked from commit 81caf72)
Merged
3 tasks
kalleep
added a commit
that referenced
this pull request
Feb 11, 2026
…e.match [backport] (#5495) ## Backport of #5460 This PR backports #5460 to release/v1.13. ### Original PR Author @kalleep ### Description ### Pull Request Details When reloading config for `loki.process` we have had issues where metrics would be registered multiple times. It was fixed in #1292. But if you have metrics in `stage.match` you will hit the same issue because we never cleaned them up: ``` stage.match { selector = `{ test="" }` stage.metrics { metric.counter { name = "counter" description = "some metric desc" action = "inc" match_all = true max_idle_duration = "12h" } } } ``` ### Issue(s) fixed by this Pull Request ### Notes to the Reviewer Test added in pr fails on main ### PR Checklist <!-- Remove items that do not apply. For completed items, change [ ] to [x]. --> - [ ] Documentation added - [x] Tests updated - [ ] Config converters updated --- *This backport was created automatically.* Co-authored-by: Karl Persson <23356117+kalleep@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Details
When reloading config for
loki.processwe have had issues where metrics would be registered multiple times. It was fixed in #1292. But if you have metrics instage.matchyou will hit the same issue because we never cleaned them up:Issue(s) fixed by this Pull Request
Notes to the Reviewer
Test added in pr fails on main
PR Checklist