Fix bug with loki.process metrics stage during config reload#1292
Merged
Fix bug with loki.process metrics stage during config reload#1292
Conversation
Contributor
|
Doc changes look OK |
thampiotr
approved these changes
Jul 15, 2024
Contributor
thampiotr
left a comment
There was a problem hiding this comment.
Looks good, other than the tests need fixing
0ebfbb2 to
edf3056
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
This bugfix is ported from a PR which was already merged to Grafana Agent. The behaviour in Alloy is different from Agent Static mode. Static mode would always log an error during config reload. Alloy doesn't log any errors. Also, reloading the config if it hasn't changed works ok and the metrics stage keeps working fine. However, if the metrics stage is changed to remove certain metrics, those metrics will still be present even after the next config reload. Their values will remain frozen in time. If they are added to the config later, then they won't resume working - they'll remain frozen.
Which issue(s) this PR fixes
Related to an issue in the Agent repo.
PR Checklist