Fix issue with config reload when using a log pipeline with a metric stage#6971

Merged

ptodev merged 4 commits intomainfrom

ptodev/duplicate-metric-promtail

Jul 15, 2024

Contributor

ptodev commented Jun 27, 2024 •

edited

Loading

PR Description

There is a longstanding bug which prevents the agent config from being reloaded when there is a metrics stage in a logging pipeline.

Which issue(s) this PR fixes

Fixes #2754

PR Checklist

CHANGELOG.md updated
Documentation added
Tests updated
Config converters updated

ptodev force-pushed the ptodev/duplicate-metric-promtail branch 3 times, most recently from 9b54c7c to 9cd3ec8 Compare

July 8, 2024 18:05

ptodev mentioned this pull request

Fix issue with unnecessary config reload in static mode #6977

Merged

4 tasks

ptodev force-pushed the ptodev/duplicate-metric-promtail branch 2 times, most recently from 1657203 to 5b9c933 Compare

July 11, 2024 12:52


          Fix bug with unnecessary config reload

8f3ab0c

ptodev force-pushed the ptodev/duplicate-metric-promtail branch from 5b9c933 to 8f3ab0c Compare

July 11, 2024 12:53

ptodev marked this pull request as ready for review

July 11, 2024 12:53

ptodev requested a review from clayton-cornell as a code owner

July 11, 2024 12:53

thampiotr reviewed

View reviewed changes

internal/component/loki/process/process_test.go Outdated Show resolved Hide resolved

thampiotr reviewed

View reviewed changes

internal/component/loki/process/process_test.go Outdated Show resolved Hide resolved

thampiotr reviewed

View reviewed changes

internal/component/loki/process/process_test.go Outdated Show resolved Hide resolved

thampiotr reviewed

View reviewed changes

internal/component/loki/process/process_test.go Outdated Show resolved Hide resolved

thampiotr reviewed

View reviewed changes

internal/component/loki/process/process_test.go Outdated Show resolved Hide resolved

thampiotr reviewed

View reviewed changes

internal/component/loki/process/process_test.go Outdated Show resolved Hide resolved

thampiotr reviewed

View reviewed changes

internal/util/unregisterer.go Show resolved Hide resolved

internal/util/unregisterer.go Show resolved Hide resolved

static/traces/traces_test.go Show resolved Hide resolved

clayton-cornell reviewed

View reviewed changes

docs/sources/flow/reference/components/loki.process.md Outdated Show resolved Hide resolved

clayton-cornell added the type/docs label

ptodev and others added 3 commits

July 12, 2024 16:07


          Apply suggestions from code review

9eb4221

Co-authored-by: Clayton Cornell <131809008+clayton-cornell@users.noreply.github.com>
Co-authored-by: Piotr <17101802+thampiotr@users.noreply.github.com>


          Refactor Flow unit test to make it more readable.

9dd6c14


          Add comments, prettify tests.

54980a9

ptodev requested a review from thampiotr

July 15, 2024 10:44

thampiotr approved these changes

View reviewed changes

ptodev requested a review from clayton-cornell

July 15, 2024 12:18

ptodev merged commit 0936175 into main

ptodev deleted the ptodev/duplicate-metric-promtail branch

July 15, 2024 12:24

ptodev mentioned this pull request

Fix bug with loki.process metrics stage during config reload grafana/alloy#1292

Merged

4 tasks

github-actions bot added the frozen-due-to-age label

github-actions bot locked as resolved and limited conversation to collaborators

ptodev mentioned this pull request

Fix bug with loki.process metrics stage during config reload grafana/alloy#1292

Merged

4 tasks

github-actions bot added the frozen-due-to-age label

github-actions bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

frozen-due-to-age type/docs