Skip to content

Apply excludes to originally requested dependency#36444

Merged
jvandort merged 1 commit into
release9xfrom
jvandort/iss/36331/apply-excludes-to-requested-dependency
Jan 27, 2026
Merged

Apply excludes to originally requested dependency#36444
jvandort merged 1 commit into
release9xfrom
jvandort/iss/36331/apply-excludes-to-requested-dependency

Conversation

@jvandort

Copy link
Copy Markdown
Member

This was originally introduced in #34927 , but there was no test to verify this behavior. Now, we add a test to verify that exclusions are applied to dependencies before and after substitution

Fixes #36331

Reviewing cheatsheet

Before merging the PR, comments starting with

  • ❌ ❓must be fixed
  • 🤔 💅 should be fixed
  • 💭 may be fixed
  • 🎉 celebrate happy things

@jvandort jvandort self-assigned this Jan 26, 2026
@jvandort jvandort added this to the 9.3.1 milestone Jan 26, 2026
@jvandort

Copy link
Copy Markdown
Member Author

@bot-gradle test rfr

@bot-gradle

This comment has been minimized.

@bot-gradle

Copy link
Copy Markdown
Collaborator

The following builds have failed:

@jvandort jvandort marked this pull request as ready for review January 26, 2026 15:15
@jvandort jvandort requested a review from a team as a code owner January 26, 2026 15:15
@jvandort jvandort requested a review from ghale January 26, 2026 15:15
This was originally introduced in #34927 , but
there was no test to verify this behavior. Now, we add a test to verify that exclusions
are applied to dependencies before and after substitution
@jvandort jvandort force-pushed the jvandort/iss/36331/apply-excludes-to-requested-dependency branch from a743def to ddce18f Compare January 26, 2026 16:35
@jvandort jvandort requested a review from a team as a code owner January 26, 2026 16:35
@jvandort jvandort changed the base branch from release to release9x January 26, 2026 16:35
@jvandort jvandort requested review from big-guy and ljacomet and removed request for ghale January 26, 2026 16:36
@jvandort jvandort added this pull request to the merge queue Jan 26, 2026
Merged via the queue into release9x with commit d8124e6 Jan 27, 2026
11 checks passed
@jvandort jvandort deleted the jvandort/iss/36331/apply-excludes-to-requested-dependency branch January 27, 2026 01:12
jvandort added a commit that referenced this pull request Apr 16, 2026
@jvandort jvandort mentioned this pull request Apr 16, 2026
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants