Re-use Scala compiler between runs#20580
Re-use Scala compiler between runs#20580bot-gradle merged 1 commit intogradle:masterfrom ashwinpankaj:ashwinpankaj/scala
Conversation
|
Thanks for the PR. Do we need to add tests? |
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
|
@donat can you please take a look at the latest changes? |
donat
left a comment
There was a problem hiding this comment.
Sorry for the late reply. Looks good!
I only found one thing to improve: we should use Gradle's object factory to avoid the null check for the new property. It's the same pattern as what GroovyCompileOptions uses.
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/api/tasks/scala/ScalaCompile.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/api/tasks/scala/ScalaCompile.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/BaseScalaCompileOptions.java
Outdated
Show resolved
Hide resolved
subprojects/scala/src/main/java/org/gradle/language/scala/tasks/AbstractScalaCompile.java
Outdated
Show resolved
Hide resolved
|
@bot-gradle test rfm please |
|
OK, I've already triggered the following builds for you: |
|
@donat is there a doc on the release schedule for gradle ? I would like to know when this will be available. Also, do we have a process for backporting the fix to a previous release? |
|
@donat any updates on getting this merged? |
|
@donat any updates on merging this PR ? |
|
The changes unearthed an internal issue. I started investigating a couple of days ago but I got dragged into another task. Nonetheless, you can expect this feature to be part of Gradle 7.6. |
Signed-off-by: Ashwin Pankaj <apankaj@confluent.io>
|
@bot-gradle test and merge |
|
OK, I've already triggered a build for you. |
…ptions.keepAliveMode property #20580 introduced `keepAliveOption`. The changes work fine, although a few things are missing, fixed by this PR: - Add test coverage - Rename keepAliveOption to keepAliveMode - Get ObjectFactory reference once per AbstractScalaCompile constructor - Set convention value in ScalaBasePlugin class - Use enum property to enforce configuration time validation errors Co-authored-by: Donat Csikos <donat@gradle.com>
Related to #20579
Signed-off-by: Ashwin Pankaj apankaj@confluent.io