Improve the implementation of scalaCompileOptions.keepAliveMode property #21307
Merged
bot-gradle merged 1 commit intomasterfrom Jul 21, 2022
Merged
Improve the implementation of scalaCompileOptions.keepAliveMode property #21307bot-gradle merged 1 commit intomasterfrom
bot-gradle merged 1 commit intomasterfrom
Conversation
ba6b3c0 to
932e2a6
Compare
932e2a6 to
80b8302
Compare
This change introduces the following improvements: - Add test coverage - Rename keepAliveOption to keepAliveMode - Get ObjectFactory reference once per AbstractScalaCompile constructor - Set convention value in ScalaBasePlugin class - Use enum property to enforce configuration time validation errors
80b8302 to
38e8421
Compare
h0tk3y
approved these changes
Jul 21, 2022
| @Incubating | ||
| public enum KeepAliveMode { | ||
| /** | ||
| * The compiler is kept alive for a session. |
Member
There was a problem hiding this comment.
Nit: maybe clarify here what a session is?
Member
Author
|
@bot-gradle test and merge |
Collaborator
|
No milestone for this PR. Please set a milestone and retry. |
Member
Author
|
cc @big-guy |
Member
Author
|
@bot-gradle test and merge |
Collaborator
|
OK, I've already triggered a build for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#20580 introduced
keepAliveOption. The changes work fine, although a few things are missing, fixed by this PR: