Remove the usage of the global metadata/index.json from the nbt plugins#829
Merged
jormundur00 merged 6 commits intomasterfrom Feb 11, 2026
Merged
Remove the usage of the global metadata/index.json from the nbt plugins#829jormundur00 merged 6 commits intomasterfrom
jormundur00 merged 6 commits intomasterfrom
Conversation
cfca9a4 to
290ef72
Compare
Member
Author
|
With the usage of the The plan is to, once both PRs are approved for merging:
@vjovanov @melix please take a look at both this PR and the Reachability Metadata PR when you have the time, as the |
vjovanov
previously approved these changes
Feb 10, 2026
776f79e to
3b416ad
Compare
3b416ad to
888dc2a
Compare
vjovanov
previously approved these changes
Feb 11, 2026
vjovanov
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we remove the legacy repository-wide
metadata/index.jsonand switch fully to per-moduleindex.jsonfiles as the single source of truth for reachability metadata discovery and dependency expansion.Motivation:
groupId/artifactId/index.json. The outermetadata/index.jsonwas redundant and a frequent source of confusion during packaging and updates.Summary of changes:
metadata/index.json. Discovery and resolution now operate exclusively on per-moduleindex.json.G:A), we include its own module directory and the conventional directories of any modules listed under "requires" inG/A/index.json.io.netty:netty-all) are included themselves and also expand their “requires” to bring in dependent module directories.As running changes in this PR depend on the reachability metadata repository PR which removes this
metadata/index.jsonfile, and the reachability metadata PR depends on buildtools working with this new format to test in the CI, the merge/release process of these PRs should have the following order:Please review this PR in conjunction with the reachability metadata PR.
The CI tests in this PR all fail due to:
(as the reachability metadata used in the latest release supports 3 schema files). Without removing the check for the 3rd schema (the global
metadata/index.jsonschema) the CI tests all pass. Once the reachability metadata PR is merged and the new release is out, the CI on this PR will be fixed.Fixes: #802