Remove global metadata/index.json file and its usage#960
Closed
jormundur00 wants to merge 3 commits intomasterfrom
Closed
Remove global metadata/index.json file and its usage#960jormundur00 wants to merge 3 commits intomasterfrom
jormundur00 wants to merge 3 commits intomasterfrom
Conversation
This was referenced Jan 26, 2026
2a5eb6e to
4bb1230
Compare
4bb1230 to
509101f
Compare
Member
Author
|
Closed to rename branch (as we want to have mirror branch names on this repo and NBT). New PR is here: #983. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
In this PR we remove the global
index.jsonfile located atmetadata/index.jsonto simplify new metadata addition (so we only need to create/maintain oneindex.jsonfile located atmetadata/groupId/artifactId/index.jsonper library artifact).To do this, we move the
allowed-packagesandrequiresfields to the innerindex.json, as this is data that only the global one had previously. As themodulefield was used to map between the global and inner index files, we remove this field as it was redundant (the information it keeps can always be resolved from the inner-index's path). All library metadata resolution is now based on file paths (so every library is strictly inmetadata/<groupId>/<artifactId>). Thescaffoldand other tasks which generate these metadata directories have also been updated accordingly to match the new format.As these changes include relatively major changes to the index structure, the remaining schema version was bumped from
1.0.0to2.0.0.As running changes in this PR depend on the buildtools PR which adds support for the removal of the
metadata/index.jsonfile, and this PR depends on buildtools working with the new format to successfully pass CI, the merge/release process of these PRs should have the following order:Fixes: #847