Use "get the entry point" algorithm where necessary.#4470
Merged
jimblandy merged 1 commit intogpuweb:mainfrom Feb 2, 2024
Merged
Use "get the entry point" algorithm where necessary.#4470jimblandy merged 1 commit intogpuweb:mainfrom
jimblandy merged 1 commit intogpuweb:mainfrom
Conversation
Contributor
|
Previews, as seen when this build job started (e01c5b2): |
kainino0x
approved these changes
Feb 1, 2024
Contributor
kainino0x
left a comment
There was a problem hiding this comment.
Content LGTM, copyediting comments
e073e6d to
d934032
Compare
Change references to `GPUProgrammableStage.entryPoint`, which is no longer required (gpuweb#4387), to uses of the "get the entry point" algorithm. Rather than talking about resources "statically used" by a GPUProgrammableStage, talk about resources "statically used" by a specific entry point. Use "get the entry point" as necessary to determine the relevant entry point.
d934032 to
e01c5b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change references to
GPUProgrammableStage.entryPoint, which is no longer required (#4387), to uses of the "get the entry point" algorithm.Rather than talking about resources "statically used" by a GPUProgrammableStage, talk about resources "statically used" by a specific entry point. Use "get the entry point" as necessary to determine the relevant entry point.