Do not always require GPUProgrammableStage.entryPoint#4387
Merged
Conversation
Contributor
|
Previews, as seen when this build job started (de0524b): |
Kangz
approved these changes
Nov 20, 2023
Contributor
Kangz
left a comment
There was a problem hiding this comment.
Yay! LGTM but let's wait for editors to merge.
kainino0x
approved these changes
Nov 20, 2023
Contributor
kainino0x
left a comment
There was a problem hiding this comment.
LGTM with a bunch of editorial nits since we're here editing this
kainino0x
reviewed
Nov 20, 2023
kainino0x
reviewed
Nov 20, 2023
kainino0x
reviewed
Nov 20, 2023
This was referenced Nov 23, 2023
copybara-service bot
pushed a commit
to google/dawn
that referenced
this pull request
Nov 24, 2023
Spec: gpuweb/gpuweb#4387 Bug: dawn:2254 Change-Id: I51c67253b095f5daf59dac378624b6bc38fe524d Reviewed-on: https://dawn-review.googlesource.com/c/dawn/+/161901 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Kokoro: Kokoro <noreply+kokoro@google.com>
This was referenced Nov 24, 2023
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 27, 2023
Intent to ship: https://groups.google.com/a/chromium.org/g/blink-dev/c/k_gcnAUinT0 Spec: gpuweb/gpuweb#4387 Bug: dawn:2254 Change-Id: I134e2706c5104271b7ec12aaa25f801d7ba0e0e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5057294 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Fr <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/main@{#1229320}
jimblandy
added a commit
to jimblandy/gpuweb
that referenced
this pull request
Jan 31, 2024
Change references to `GPUProgrammableStage.entryPoint`, which is no longer required (gpuweb#4387), to uses of the "get the entry point" algorithm. Rather than talking about resources "statically used" by a GPUProgrammableStage, talk about resources "statically used" by a specific entry point. Use "get the entry point" as necessary to determine the relevant entry point.
jimblandy
added a commit
to jimblandy/gpuweb
that referenced
this pull request
Feb 2, 2024
Change references to `GPUProgrammableStage.entryPoint`, which is no longer required (gpuweb#4387), to uses of the "get the entry point" algorithm. Rather than talking about resources "statically used" by a GPUProgrammableStage, talk about resources "statically used" by a specific entry point. Use "get the entry point" as necessary to determine the relevant entry point.
jimblandy
added a commit
to jimblandy/gpuweb
that referenced
this pull request
Feb 2, 2024
Change references to `GPUProgrammableStage.entryPoint`, which is no longer required (gpuweb#4387), to uses of the "get the entry point" algorithm. Rather than talking about resources "statically used" by a GPUProgrammableStage, talk about resources "statically used" by a specific entry point. Use "get the entry point" as necessary to determine the relevant entry point.
jimblandy
added a commit
to jimblandy/gpuweb
that referenced
this pull request
Feb 2, 2024
Change references to `GPUProgrammableStage.entryPoint`, which is no longer required (gpuweb#4387), to uses of the "get the entry point" algorithm. Rather than talking about resources "statically used" by a GPUProgrammableStage, talk about resources "statically used" by a specific entry point. Use "get the entry point" as necessary to determine the relevant entry point.
jimblandy
added a commit
that referenced
this pull request
Feb 2, 2024
Change references to `GPUProgrammableStage.entryPoint`, which is no longer required (#4387), to uses of the "get the entry point" algorithm. Rather than talking about resources "statically used" by a GPUProgrammableStage, talk about resources "statically used" by a specific entry point. Use "get the entry point" as necessary to determine the relevant entry point.
juj
added a commit
to juj/wasm_webgpu
that referenced
this pull request
Mar 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to move #4342 forward, this PR makes WebGPU spec not always require
GPUProgrammableStage.entryPointas discussed in https://github.com/gpuweb/gpuweb/wiki/GPU-Web-2023-11-08#default-entrypoints-to-shader-modules-4342-corentin-is-very-excited-about-this-tiny-addition@kainino0x Can you have a look at this?